Skip to content

Simplify logic in Diagonal-Tridiagonal multiplication #1338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented May 5, 2025

This improves performance in small ::Diagonal * ::Tridiagonal multiplications:

julia> D = Diagonal(1:3); T = Tridiagonal(1:2, 1:3, 1:2); C = similar(T);

julia> @btime mul!($C, $D, $T);
  43.435 ns (0 allocations: 0 bytes) # master
  14.725 ns (0 allocations: 0 bytes) # this PR

This also improves TTFX

julia> @time mul!(C, D, T);
  0.192970 seconds (451.55 k allocations: 22.211 MiB, 99.99% compilation time) # master
  0.129910 seconds (273.38 k allocations: 13.351 MiB, 99.98% compilation time) # this PR

@jishnub jishnub added performance Must go faster ttfx The change pertains to first-call latency labels May 5, 2025
Copy link

codecov bot commented May 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.74%. Comparing base (5165fd3) to head (993462b).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1338      +/-   ##
==========================================
- Coverage   93.74%   93.74%   -0.01%     
==========================================
  Files          34       34              
  Lines       15775    15766       -9     
==========================================
- Hits        14789    14780       -9     
  Misses        986      986              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jishnub jishnub requested a review from dkarrasch May 7, 2025 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Must go faster ttfx The change pertains to first-call latency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant