Skip to content

specialize kron!(::Diagonal, ::Diagonal, ::Diagonal) #1392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 1, 2025

Conversation

tam724
Copy link
Contributor

@tam724 tam724 commented Jun 27, 2025

see #1391.
Implements a specialized version of kron! that dispatches on ::Diagonal as the first argument.

Copy link

codecov bot commented Jun 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.84%. Comparing base (db95a2a) to head (2ffcafa).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1392   +/-   ##
=======================================
  Coverage   93.83%   93.84%           
=======================================
  Files          34       34           
  Lines       15823    15826    +3     
=======================================
+ Hits        14848    14852    +4     
+ Misses        975      974    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dkarrasch
Copy link
Member

Since the 2-arg method doesn't redirect to the in-place method, we would need a test for this.

Copy link
Member

@dkarrasch dkarrasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're at it, we might as well "fix" the style bits. Otherwise LGTM.

@tam724
Copy link
Contributor Author

tam724 commented Jun 30, 2025

Thanks for the review. I added the whitespaces.

@dkarrasch
Copy link
Member

Not sure why it says those lines are not covered... This LGTM, so I'll merge.

@dkarrasch dkarrasch merged commit b7fd696 into JuliaLang:master Jul 1, 2025
4 checks passed
@dkarrasch
Copy link
Member

Thank you very much, @tam724!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants