-
-
Notifications
You must be signed in to change notification settings - Fork 25
specialize kron!(::Diagonal, ::Diagonal, ::Diagonal) #1392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1392 +/- ##
=======================================
Coverage 93.83% 93.84%
=======================================
Files 34 34
Lines 15823 15826 +3
=======================================
+ Hits 14848 14852 +4
+ Misses 975 974 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Since the 2-arg method doesn't redirect to the in-place method, we would need a test for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're at it, we might as well "fix" the style bits. Otherwise LGTM.
Thanks for the review. I added the whitespaces. |
Not sure why it says those lines are not covered... This LGTM, so I'll merge. |
Thank you very much, @tam724! |
see #1391.
Implements a specialized version of
kron!
that dispatches on ::Diagonal as the first argument.