Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DONOTMERGE] Switch llvm source build to v20 #57658

Open
wants to merge 26 commits into
base: master
Choose a base branch
from

Conversation

Zentrik
Copy link
Member

@Zentrik Zentrik commented Mar 6, 2025

This is for testing with pkgeval before we have built on yggdrasil

@nanosoldier runtests(configuration = (buildflags=["LLVM_ASSERTIONS=1", "FORCE_ASSERTIONS=1", "USE_BINARYBUILDER_LLVM=0"],), vs_configuration = (buildflags=["LLVM_ASSERTIONS=1", "FORCE_ASSERTIONS=1"],))

@Zentrik Zentrik added DO NOT MERGE Do not merge this PR! external dependencies Involves LLVM, OpenBLAS, or other linked libraries labels Mar 6, 2025
@maleadt
Copy link
Member

maleadt commented Mar 9, 2025

PkgEval got restarted:

@nanosoldier runtests(configuration = (buildflags=["LLVM_ASSERTIONS=1", "FORCE_ASSERTIONS=1", "USE_BINARYBUILDER_LLVM=0"],), vs_configuration = (buildflags=["LLVM_ASSERTIONS=1", "FORCE_ASSERTIONS=1"],))

Only one job ahead of this, so it should report within 2 days.

@maleadt
Copy link
Member

maleadt commented Mar 10, 2025

The build failed:

CMake 3.20.0 or higher is required.  You are running version 3.18.4

PkgEval is currently using the latest rootfs, https://github.com/JuliaCI/rootfs-images/releases/tag/v7.10. I guess we'll need to upgrade from bullseye to bookworm, https://github.com/JuliaCI/rootfs-images/blob/e7be8086ff1285b0f333ca72884977d01aed0e1f/src/build_img/debian.jl#L17.

@giordano
Copy link
Contributor

giordano commented Mar 10, 2025

You can download cmake with contrib/download_cmake.sh, but no idea how do that for pkgeval invocations (if doable at all). But maybe the Makefile here can be hacked to force that.

@nanosoldier
Copy link
Collaborator

Your job failed. Consult the server logs for more details (cc @maleadt).

@Zentrik
Copy link
Member Author

Zentrik commented Mar 10, 2025

I forgot we added an invocation to the download cmake script for the source build, JuliaCI/julia-buildkite@552037b.

@Zentrik
Copy link
Member Author

Zentrik commented Mar 10, 2025

@maleadt would it be easy to get this fixed otherwise I'll start the llvm yggy build?

@giordano
Copy link
Contributor

Can't you run the download cmake script as part of the build script in this PR? This is just for testing anyway.

@Zentrik
Copy link
Member Author

Zentrik commented Mar 10, 2025

Can't you run the download cmake script as part of the build script in this PR? This is just for testing anyway.

Yep, ignore me then tim, I'll do that.

@Zentrik
Copy link
Member Author

Zentrik commented Mar 10, 2025

Let's see if this works

@nanosoldier runtests(configuration = (buildflags=["LLVM_ASSERTIONS=1", "FORCE_ASSERTIONS=1", "USE_BINARYBUILDER_LLVM=0"],), vs_configuration = (buildflags=["LLVM_ASSERTIONS=1", "FORCE_ASSERTIONS=1"],))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Do not merge this PR! external dependencies Involves LLVM, OpenBLAS, or other linked libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants