Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add method log_lbfgs - Riemannian logarithm using expm_frechet - #555

Closed
wants to merge 42 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
a4f64e1
add Frechet derivative and new algorithm for Stiefel logarithm
dnguyend Oct 23, 2022
a18f52e
add misc_stiefel_frechet - various files used for testing, should be …
dnguyend Oct 23, 2022
244e065
fix kwargs
dnguyend Oct 23, 2022
405f828
Proposal to add new log algorithm
dnguyend Oct 23, 2022
1f95cc2
add customized lbfgs
dnguyend Oct 28, 2022
487558d
remove Optim
dnguyend Oct 28, 2022
bb077c3
StiefelFrechet.jl
dnguyend Oct 28, 2022
e3c57a2
add minimize_lbfgs
dnguyend Oct 28, 2022
3f77b7a
continue fix
dnguyend Oct 28, 2022
3dcb407
bug for small ys
dnguyend Oct 28, 2022
d66bf21
remove skipped
dnguyend Oct 28, 2022
efd6200
remove skipped
dnguyend Oct 28, 2022
c01e2f7
remove skipped
dnguyend Oct 28, 2022
f70d75d
add case p and q have the same span
dnguyend Nov 29, 2022
ebb8706
add tests for expm_frechet, lbfgs, log_lbfgs
dnguyend Nov 29, 2022
5dda941
using formatter
dnguyend Nov 30, 2022
1c82f00
adjust sensitivity of the test
dnguyend Dec 2, 2022
41c2cb9
improve docs
dnguyend Dec 3, 2022
7f0a29a
improve docs
dnguyend Dec 3, 2022
aa53782
improve docs
dnguyend Dec 3, 2022
a9b8352
improve docs
dnguyend Dec 3, 2022
ec2755e
improve docs
dnguyend Dec 3, 2022
4d51acc
improve docs
dnguyend Dec 3, 2022
47aad34
improve docs
dnguyend Dec 3, 2022
4ab89ce
new documentation
dnguyend Dec 3, 2022
f41d35e
fix default values
dnguyend Dec 4, 2022
cc23bdd
fix default values
dnguyend Dec 4, 2022
b90f73b
fix default values
dnguyend Dec 4, 2022
9deb855
fix default values
dnguyend Dec 4, 2022
b4462ce
attempt local coverage
dnguyend Dec 4, 2022
24f9e2b
more local coverage
dnguyend Dec 4, 2022
cc3a274
Revert "fix default values"
dnguyend Dec 4, 2022
6af162b
Revert "attempt local coverage"
dnguyend Dec 4, 2022
b853ffe
more coverage
dnguyend Dec 4, 2022
1751317
fix coverage
dnguyend Dec 4, 2022
52a8a27
format files
dnguyend Dec 4, 2022
6d8b14a
fix docs
dnguyend Dec 4, 2022
556fc83
improve exit condition
dnguyend Dec 4, 2022
bec1bf6
more coverage
dnguyend Dec 4, 2022
55047d0
test coverage
dnguyend Dec 4, 2022
c0d2972
improve docs and coverage
dnguyend Dec 5, 2022
74631b9
more coverage
dnguyend Dec 5, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions docs/src/manifolds/stiefel.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,14 @@ Public = true
Private = false
```

```@autodocs
Modules = [Manifolds]
Pages = ["manifolds/StiefelFrechet.jl"]
Order = [:type, :function]
Public = true
Private = false
```

## Internal types and functions

```@autodocs
Expand Down
2 changes: 2 additions & 0 deletions docs/src/misc/internals.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,10 @@ This page documents the internal types and methods of `Manifolds.jl`'s that migh
```@docs
Manifolds.eigen_safe
Manifolds.isnormal
Manifolds.expm_frechet
Manifolds.log_safe
Manifolds.log_safe!
Manifolds.minimize
Manifolds.mul!_safe
Manifolds.nzsign
Manifolds.realify
Expand Down
8 changes: 8 additions & 0 deletions src/Manifolds.jl
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,8 @@ using StatsBase
using StatsBase: AbstractWeights

include("utils.jl")
include("expm_frechet.jl")
include("minimize_lbfgs.jl")

include("product_representations.jl")
include("differentiation/differentiation.jl")
Expand Down Expand Up @@ -345,6 +347,7 @@ include("manifolds/Stiefel.jl")
include("manifolds/StiefelEuclideanMetric.jl")
include("manifolds/StiefelCanonicalMetric.jl")
include("manifolds/StiefelSubmersionMetric.jl")
include("manifolds/StiefelFrechet.jl")
include("manifolds/Sphere.jl")
include("manifolds/SphereSymmetricMatrices.jl")
include("manifolds/Symmetric.jl")
Expand Down Expand Up @@ -659,13 +662,17 @@ export ×,
differential_canonical_project,
differential_canonical_project!,
distance,
dot_exp,
dot_exp!,
dual_basis,
einstein_tensor,
embed,
embed!,
equiv,
exp,
exp!,
exp_frechet,
exp_frechet!,
flat,
flat!,
gaussian_curvature,
Expand Down Expand Up @@ -702,6 +709,7 @@ export ×,
local_metric_jacobian,
log,
log!,
log_lbfgs,
log_local_metric_density,
manifold_dimension,
metric,
Expand Down
Loading