Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement and document parallel transport on Grassmann. #731

Merged
merged 5 commits into from
Jun 18, 2024

Conversation

kellertuer
Copy link
Member

@kellertuer kellertuer commented Jun 16, 2024

I recently noticed (p. 171 AMS08), that parallel transport on Grassmann (Stiefel representation) has a closed form in the _direction variant. So here is an implementation.
Will add tests the next few days.

🛣️

  • Test coverage
  • read documentation carefully that it renders correctly

@kellertuer kellertuer added documentation Improvements or additions to documentation extend manifold This issue proposes/asks for new functions to extend an existing manifold labels Jun 16, 2024
Copy link

codecov bot commented Jun 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.58%. Comparing base (7785932) to head (d7057fb).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #731   +/-   ##
=======================================
  Coverage   99.58%   99.58%           
=======================================
  Files         114      114           
  Lines       11230    11244   +14     
=======================================
+ Hits        11183    11197   +14     
  Misses         47       47           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kellertuer kellertuer added the Ready-for-Review A label for pull requests that are feature-ready label Jun 17, 2024
@mateuszbaran mateuszbaran added the preview docs Add this label if you want to see a PR-preview of the documentation label Jun 18, 2024
@kellertuer kellertuer merged commit 676b0f5 into master Jun 18, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation extend manifold This issue proposes/asks for new functions to extend an existing manifold preview docs Add this label if you want to see a PR-preview of the documentation Ready-for-Review A label for pull requests that are feature-ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants