Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Julia 0.5: symbol → Symbol #17

Closed
wants to merge 2 commits into from
Closed

Fix for Julia 0.5: symbol → Symbol #17

wants to merge 2 commits into from

Conversation

giordano
Copy link
Member

@giordano giordano commented Jun 7, 2016

No description provided.

@giordano
Copy link
Member Author

giordano commented Jun 7, 2016

Also OS_NAME is deprecated in Julia 0.5, but its replacement Sys.KERNEL isn't available for Julia 0.4. @static is_*() should be used instead?

@giordano
Copy link
Member Author

giordano commented Jun 7, 2016 •
edited
Loading

Uh, second commit makes Travis fail with Julia 0.4 on OS X: https://travis-ci.org/stevengj/Cubature.jl/builds/136011028 Instead the first one worked with that configuration: https://travis-ci.org/stevengj/Cubature.jl/builds/136008876 Connection issue or what? I don't have an OS X box to test with.

@giordano
Copy link
Member Author

giordano commented Jul 6, 2016

I guess this can be closed as well after pull request #19. But the problem with Sys.KERNEL is still there, probably (didn't try a recent Julia version though).

@giordano giordano closed this Jul 6, 2016
stevengj added a commit that referenced this pull request Jul 6, 2016
@stevengj
replace OS_NAME with is_foo() in build script, for 0.5 (see #17)
8dfbdaa
@stevengj
Copy link
Member

stevengj commented Jul 6, 2016

Thanks, I updated it to use is_apple() and is_windows().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giordano @stevengj