Fix for 0.6 #23
Merged
Fix for 0.6 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix vectorized function depwarn * Remove `cfunction` cache * Avoid dynamic dispatch in callback
|
This version passes tests on 0.4, 0.5 and 0.6 with JuliaLang/julia#19801. It should not have any dynamic dispatch in the callback on 0.5 and 0.6. |
|
I should mention that the fix does not rely on JuliaLang/julia#19801 anymore and should be ready to go. |
|
Thanks! Can you put together a PR to update the C-callback blog post at some point? |
|
Well, I guess it's still unclear what JuliaLang/julia#19801 will become. Currently there isn't a semantic for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cfunctioncacheDO NOT MERGE NOW!~~The broadcast fix is independent and is missing
@compat. Thecfunctionfix requires JuliaLang/julia#19801 and can also be further improved to eliminate dynamic dispatch in the callback. This is used mainly as a use/test case for JuliaLang/julia#19801. ~~