Skip to content

Address some transform-related naming inconsistencies #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 20, 2022
Merged

Conversation

oschulz
Copy link
Collaborator

@oschulz oschulz commented Jun 20, 2022

We forgot a few additional types and functions when we renamed vartransform to transport_to during the course of #62. This renames them to make things more consistent:

  • Rename VarTransformation to TransportFunction
  • Rename test_vartransform to test_transport
  • Rename NoVarTransform to NoTransport
  • Rename checked_var to checked_arg
  • Rename NoVarCheck to NoArgCheck
  • Rename internal transport helper functions

@oschulz oschulz requested review from cscherrer and mschauer June 20, 2022 01:13
@oschulz oschulz mentioned this pull request Jun 20, 2022
@github-actions
Copy link

Package name latest stable
MeasureTheory.jl

@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #63 (90c88f6) into master (648376d) will not change coverage.
The diff coverage is 71.11%.

@@           Coverage Diff           @@
##           master      #63   +/-   ##
=======================================
  Coverage   47.55%   47.55%           
=======================================
  Files          37       37           
  Lines         942      942           
=======================================
  Hits          448      448           
  Misses        494      494           
Impacted Files Coverage Δ
src/transport.jl 63.88% <62.50%> (ø)
src/getdof.jl 87.50% <80.00%> (ø)
src/combinators/power.jl 84.90% <100.00%> (ø)
src/combinators/transformedmeasure.jl 71.42% <100.00%> (ø)
src/interface.jl 96.29% <100.00%> (ø)
src/primitives/dirac.jl 70.58% <100.00%> (ø)
src/primitives/lebesgue.jl 80.95% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 648376d...90c88f6. Read the comment docs.

@oschulz
Copy link
Collaborator Author

oschulz commented Jun 20, 2022

Most names changes are straightforward, I think. I'm not sure about checked_var - I rename it to checked_arg here, but maybe that could also be misunderstood? Would checked_variate be better?

@cscherrer
Copy link
Collaborator

If it's not very user facing, how about check_support_type?

@mschauer
Copy link
Member

I am happy with checked_arg

@oschulz
Copy link
Collaborator Author

oschulz commented Jun 20, 2022

If it's not very user facing, how about check_support_type?

It doesn't just check the type, it can also check the size of arrays, etc.

@oschulz
Copy link
Collaborator Author

oschulz commented Jun 20, 2022

Are you happy with the state of this @cscherrer ?

@cscherrer
Copy link
Collaborator

@oschulz is this a minor or patch release?

@oschulz
Copy link
Collaborator Author

oschulz commented Jun 20, 2022

@oschulz is this a minor or patch release?

It'll have to be v0.12, some of these things have docstrings. So probably best to fix these naming inconsistencies now, I'd say.

@oschulz
Copy link
Collaborator Author

oschulz commented Jun 20, 2022

Ok, if I go ahead and tag this v0.12 and release it?

@github-actions
Copy link

Package name latest stable
MeasureTheory.jl

@oschulz oschulz merged commit f7b4444 into master Jun 20, 2022
@oschulz oschulz deleted the renames branch June 20, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants