Skip to content

Conversation

icweaver
Copy link
Contributor

@icweaver icweaver commented Aug 2, 2025

Just a simple find and replace for SymbolicML --> JuliaPhysics in case that is heplful

Copy link
Contributor

github-actions bot commented Aug 2, 2025

Benchmark Results (Julia v1.10)

Time benchmarks
main c2b32ac... main / c2b32ac...
Quantity/creation/Quantity(x) 3.1 ± 0.01 ns 2.79 ± 0.009 ns 1.11 ± 0.0051
Quantity/creation/Quantity(x, length=y) 3.11 ± 0.001 ns 3.41 ± 0.01 ns 0.912 ± 0.0027
Quantity/with_numbers/*real 3.11 ± 0.01 ns 3.11 ± 0.01 ns 1 ± 0.0046
Quantity/with_numbers/^int 8.67 ± 2.5 ns 8.05 ± 2.2 ns 1.08 ± 0.42
Quantity/with_numbers/^int * real 8.37 ± 2.2 ns 8.37 ± 1.9 ns 1 ± 0.34
Quantity/with_quantity/+y 4.04 ± 0.001 ns 4.04 ± 0.001 ns 1 ± 0.00035
Quantity/with_quantity//y 3.42 ± 0.01 ns 3.11 ± 0.01 ns 1.1 ± 0.0048
Quantity/with_self/dimension 3.1 ± 0.01 ns 3.1 ± 0.01 ns 0.997 ± 0.0045
Quantity/with_self/inv 3.42 ± 0.01 ns 3.11 ± 0.001 ns 1.1 ± 0.0032
Quantity/with_self/ustrip 3.1 ± 0.01 ns 2.8 ± 0.92 ns 1.11 ± 0.37
QuantityArray/broadcasting/multi_array_of_quantities 0.143 ± 0.0014 ms 0.141 ± 0.0016 ms 1.01 ± 0.015
QuantityArray/broadcasting/multi_normal_array 0.0558 ± 0.0031 ms 0.0527 ± 0.003 ms 1.06 ± 0.084
QuantityArray/broadcasting/multi_quantity_array 0.157 ± 0.00088 ms 0.157 ± 0.00086 ms 1 ± 0.0079
QuantityArray/broadcasting/x^2_array_of_quantities 24.6 ± 2.7 μs 23.8 ± 1.7 μs 1.03 ± 0.14
QuantityArray/broadcasting/x^2_normal_array 4.09 ± 0.77 μs 4.11 ± 0.76 μs 0.995 ± 0.26
QuantityArray/broadcasting/x^2_quantity_array 7.03 ± 0.29 μs 6.93 ± 0.27 μs 1.01 ± 0.058
QuantityArray/broadcasting/x^4_array_of_quantities 0.0813 ± 0.00055 ms 0.0816 ± 0.00056 ms 0.997 ± 0.0096
QuantityArray/broadcasting/x^4_normal_array 0.0497 ± 0.00017 ms 0.0498 ± 0.00015 ms 1 ± 0.0046
QuantityArray/broadcasting/x^4_quantity_array 0.0499 ± 0.00018 ms 0.0529 ± 0.003 ms 0.943 ± 0.054
time_to_load 0.186 ± 0.0037 s 0.184 ± 0.00049 s 1.01 ± 0.02
Memory benchmarks
main c2b32ac... main / c2b32ac...
Quantity/creation/Quantity(x) 0 allocs: 0 B 0 allocs: 0 B
Quantity/creation/Quantity(x, length=y) 0 allocs: 0 B 0 allocs: 0 B
Quantity/with_numbers/*real 0 allocs: 0 B 0 allocs: 0 B
Quantity/with_numbers/^int 0 allocs: 0 B 0 allocs: 0 B
Quantity/with_numbers/^int * real 0 allocs: 0 B 0 allocs: 0 B
Quantity/with_quantity/+y 0 allocs: 0 B 0 allocs: 0 B
Quantity/with_quantity//y 0 allocs: 0 B 0 allocs: 0 B
Quantity/with_self/dimension 0 allocs: 0 B 0 allocs: 0 B
Quantity/with_self/inv 0 allocs: 0 B 0 allocs: 0 B
Quantity/with_self/ustrip 0 allocs: 0 B 0 allocs: 0 B
QuantityArray/broadcasting/multi_array_of_quantities 2 allocs: 0.382 MB 2 allocs: 0.382 MB 1
QuantityArray/broadcasting/multi_normal_array 2 allocs: 0.0763 MB 2 allocs: 0.0763 MB 1
QuantityArray/broadcasting/multi_quantity_array 2 allocs: 0.0763 MB 2 allocs: 0.0763 MB 1
QuantityArray/broadcasting/x^2_array_of_quantities 2 allocs: 0.382 MB 2 allocs: 0.382 MB 1
QuantityArray/broadcasting/x^2_normal_array 2 allocs: 0.0763 MB 2 allocs: 0.0763 MB 1
QuantityArray/broadcasting/x^2_quantity_array 2 allocs: 0.0763 MB 2 allocs: 0.0763 MB 1
QuantityArray/broadcasting/x^4_array_of_quantities 2 allocs: 0.382 MB 2 allocs: 0.382 MB 1
QuantityArray/broadcasting/x^4_normal_array 2 allocs: 0.0763 MB 2 allocs: 0.0763 MB 1
QuantityArray/broadcasting/x^4_quantity_array 2 allocs: 0.0763 MB 2 allocs: 0.0763 MB 1
time_to_load 0.153 k allocs: 14.5 kB 0.153 k allocs: 14.5 kB 1

Copy link
Contributor

github-actions bot commented Aug 2, 2025

Benchmark Results (Julia v1)

Time benchmarks
main c2b32ac... main / c2b32ac...
Quantity/creation/Quantity(x) 3.1 ± 0.01 ns 3.1 ± 0.01 ns 1 ± 0.0046
Quantity/creation/Quantity(x, length=y) 3.73 ± 0.009 ns 3.73 ± 0.01 ns 1 ± 0.0036
Quantity/with_numbers/*real 2.79 ± 0 ns 2.79 ± 0.001 ns 1 ± 0.00036
Quantity/with_numbers/^int 8.68 ± 2.2 ns 8.67 ± 2.2 ns 1 ± 0.35
Quantity/with_numbers/^int * real 9.29 ± 2.2 ns 9.29 ± 2.2 ns 1 ± 0.33
Quantity/with_quantity/+y 4.35 ± 0.01 ns 4.35 ± 0.0022 ns 1 ± 0.0024
Quantity/with_quantity//y 3.42 ± 0.011 ns 3.41 ± 0.01 ns 1 ± 0.0044
Quantity/with_self/dimension 3.11 ± 0.001 ns 4.02 ± 0.01 ns 0.773 ± 0.0019
Quantity/with_self/inv 3.11 ± 0.001 ns 3.11 ± 0.001 ns 1 ± 0.00046
Quantity/with_self/ustrip 3.1 ± 0.01 ns 3.1 ± 0.01 ns 1 ± 0.0046
QuantityArray/broadcasting/multi_array_of_quantities 0.0905 ± 0.00088 ms 0.0904 ± 0.0012 ms 1 ± 0.017
QuantityArray/broadcasting/multi_normal_array 0.0498 ± 0.00027 ms 0.0498 ± 0.00028 ms 1 ± 0.0078
QuantityArray/broadcasting/multi_quantity_array 0.0623 ± 0.00027 ms 0.0623 ± 0.00029 ms 1 ± 0.0064
QuantityArray/broadcasting/x^2_array_of_quantities 12.7 ± 1.9 μs 12.9 ± 1.8 μs 0.99 ± 0.2
QuantityArray/broadcasting/x^2_normal_array 2.1 ± 1.7 μs 2.07 ± 1.5 μs 1.01 ± 1.1
QuantityArray/broadcasting/x^2_quantity_array 3.48 ± 0.13 μs 3.47 ± 0.11 μs 1 ± 0.049
QuantityArray/broadcasting/x^4_array_of_quantities 0.0844 ± 0.00085 ms 0.0844 ± 0.0008 ms 1 ± 0.014
QuantityArray/broadcasting/x^4_normal_array 0.0497 ± 0.00018 ms 0.0497 ± 0.00017 ms 1 ± 0.005
QuantityArray/broadcasting/x^4_quantity_array 0.0499 ± 0.0092 ms 0.0498 ± 0.003 ms 1 ± 0.19
time_to_load 0.2 ± 0.0011 s 0.2 ± 0.0019 s 1 ± 0.011
Memory benchmarks
main c2b32ac... main / c2b32ac...
Quantity/creation/Quantity(x) 0 allocs: 0 B 0 allocs: 0 B
Quantity/creation/Quantity(x, length=y) 0 allocs: 0 B 0 allocs: 0 B
Quantity/with_numbers/*real 0 allocs: 0 B 0 allocs: 0 B
Quantity/with_numbers/^int 0 allocs: 0 B 0 allocs: 0 B
Quantity/with_numbers/^int * real 0 allocs: 0 B 0 allocs: 0 B
Quantity/with_quantity/+y 0 allocs: 0 B 0 allocs: 0 B
Quantity/with_quantity//y 0 allocs: 0 B 0 allocs: 0 B
Quantity/with_self/dimension 0 allocs: 0 B 0 allocs: 0 B
Quantity/with_self/inv 0 allocs: 0 B 0 allocs: 0 B
Quantity/with_self/ustrip 0 allocs: 0 B 0 allocs: 0 B
QuantityArray/broadcasting/multi_array_of_quantities 3 allocs: 0.382 MB 3 allocs: 0.382 MB 1
QuantityArray/broadcasting/multi_normal_array 3 allocs: 0.0764 MB 3 allocs: 0.0764 MB 1
QuantityArray/broadcasting/multi_quantity_array 3 allocs: 0.0764 MB 3 allocs: 0.0764 MB 1
QuantityArray/broadcasting/x^2_array_of_quantities 3 allocs: 0.382 MB 3 allocs: 0.382 MB 1
QuantityArray/broadcasting/x^2_normal_array 3 allocs: 0.0764 MB 3 allocs: 0.0764 MB 1
QuantityArray/broadcasting/x^2_quantity_array 3 allocs: 0.0764 MB 3 allocs: 0.0764 MB 1
QuantityArray/broadcasting/x^4_array_of_quantities 3 allocs: 0.382 MB 3 allocs: 0.382 MB 1
QuantityArray/broadcasting/x^4_normal_array 3 allocs: 0.0764 MB 3 allocs: 0.0764 MB 1
QuantityArray/broadcasting/x^4_quantity_array 3 allocs: 0.0764 MB 3 allocs: 0.0764 MB 1
time_to_load 0.159 k allocs: 11.2 kB 0.159 k allocs: 11.2 kB 1

Copy link

codecov bot commented Aug 2, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@MilesCranmer
Copy link
Member

Thanks

The coveralls one doesn’t work though. Should be updated to codecov I think

@icweaver
Copy link
Contributor Author

icweaver commented Aug 2, 2025

Ah, right, #179

Does it take a sec for org moves to update on codecov's end? I'm currently seeing this for the badge at https://codecov.io/gh/JuliaPhysics/DynamicQuantities.jl/graph/badge.svg

image

@icweaver
Copy link
Contributor Author

icweaver commented Aug 5, 2025

Not sure if related, but I saw that Ronan seemed to be hitting a similar issue with codecov

@MilesCranmer MilesCranmer merged commit 3e4e19d into JuliaPhysics:main Aug 6, 2025
7 checks passed
@icweaver
Copy link
Contributor Author

icweaver commented Aug 6, 2025

oop, sorry, I don't think I made the coveralls --> codecov change yet. Glad to see it's working now! Do you want this as a separate PR, or were you just planning to change the README on your end?

@MilesCranmer
Copy link
Member

Sure a separate PR works!

@icweaver icweaver deleted the update-links branch August 6, 2025 19:02
@icweaver
Copy link
Contributor Author

icweaver commented Aug 6, 2025

For sure! #184

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants