Add NaNMath extension for Unitful quantities #824
+18
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #824 +/- ##
=========================================
Coverage ? 89.53%
=========================================
Files ? 22
Lines ? 1701
Branches ? 0
=========================================
Hits ? 1523
Misses ? 178
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
sostock
reviewed
Dec 5, 2025
Comment on lines
+5
to
+6
| NaNMath.sqrt(q::Quantity) = NaNMath.sqrt(ustrip(q))*sqrt(unit(q)) | ||
| NaNMath.pow(q::Quantity, r) = NaNMath.pow(ustrip(q), r)*unit(q)^r |
Collaborator
There was a problem hiding this comment.
Suggested change
| NaNMath.sqrt(q::Quantity) = NaNMath.sqrt(ustrip(q))*sqrt(unit(q)) | |
| NaNMath.pow(q::Quantity, r) = NaNMath.pow(ustrip(q), r)*unit(q)^r | |
| NaNMath.sqrt(q::Unitful.AbstractQuantity) = NaNMath.sqrt(ustrip(q))*sqrt(unit(q)) | |
| NaNMath.pow(q::Unitful.AbstractQuantity, r) = NaNMath.pow(ustrip(q), r)*unit(q)^r |
Collaborator
|
I wonder whether it makes sense to define these functions on dimensions and units as well, not just quantities? Of course, they are not different from the regular |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of NaNMath.jl doesn't work on Unitful quantities; e.g.
should return
NaN*u"m"but currently errors. (The point of NaNMath is that it should return NaN rather than error, which is helpful when e.g. adaptive solvers get outside of feasible space.)This was discussed on the NaNMath side at JuliaMath/NaNMath.jl#86 but that seems to have stalled out. The extension to Unitful of the
sqrtandpowmethods is easy enough; NaNMath has other functions (e.g. for functions likesinthat take dimensionless input, or aggregators likesum) but I think those are not as necessary.