More stable notebook file parsing when cell order is missing#3285
Merged
Conversation
This was referenced Jul 1, 2025
KeithWM
suggested changes
Jul 1, 2025
KeithWM
left a comment
KeithWM
left a comment
There was a problem hiding this comment.
I did my best to do some review because I do really appreciate the effort, but I'm not sure how valuable my comments are.
Member
Author
|
Thanks! |
KeithWM
approved these changes
Jul 3, 2025
| cell_id = if cell_id_parsed isa UUID | ||
| if haskey(collected_cells, cell_id_parsed) | ||
| @warn "Cell ID appears multiple times in the file. Generating a new one." | ||
| uuid1() |
There was a problem hiding this comment.
Would return statements help clarify the code here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out from #3279, to make Pluto more future-proof for when we release #3179.
This PR makes Pluto better at opening notebook files that are missing the
Cell Ordersection at the bottom of the file.Try this Pull Request!
Open Julia and type: