Skip to content

New package: Harbor v1.0.0 #126935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

JuliaRegistrator
Copy link
Contributor

UUID: af79dbb9-1a80-47ad-8928-192a4af69376
Repo: https://github.com/JuliaServices/Harbor.jl.git
Tree: e2d5e800ec9ddb18d5ab7793a4e934354826afb8

Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
Copy link
Contributor

Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human.

1. New package registration

Please make sure that you have read the package naming guidelines.

2. AutoMerge Guidelines are all met! ✅

Your new package registration met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed.

3. To pause or stop registration

If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

Tip: You can edit blocking comments to add [noblock] in order to unblock auto-merging.

@goerz
Copy link
Member

goerz commented Mar 15, 2025

It seems that the links to the documentation are currently broken. For a v1.0.0 initial release, it would be especially important that the documentation is complete, as you're indicating (assuming you're following SemVer) that the package has a stable API.

I would also consider extending the "Usage" documentation in the README a little, although this might become redundant with proper full documentation.

[noblock]

@JuliaTagBot JuliaTagBot added the AutoMerge: last run blocked by comment PR blocked by one or more comments lacking the string [noblock]. label Mar 15, 2025
@quinnj
Copy link
Contributor

quinnj commented Mar 15, 2025

[noblock] Good catch @goerz, I had finally got the Documentation CI job to run successfully and it said it deployed, but I failed to actually check that the docs were published. Turns out I had to enable github pages in my repo settings. That's fixed now. I'll update the README.md as well, but I dont' believe any additional commits are required to update this registration

(you'll have to edit your comment to add [noblock] if your concerns are satisfied)

@goerz
Copy link
Member

goerz commented Mar 15, 2025

Yup, all good! Thanks for fixing the documentation! [noblock]

@JuliaTagBot JuliaTagBot removed the AutoMerge: last run blocked by comment PR blocked by one or more comments lacking the string [noblock]. label Mar 15, 2025
@JuliaTagBot JuliaTagBot merged commit 76c61eb into master Mar 18, 2025
20 checks passed
@JuliaTagBot JuliaTagBot deleted the registrator-harbor-af79dbb9-v1.0.0-1bef59405f branch March 18, 2025 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants