Fix Aqua deps_compat (Test) and piracy (treat VectorizationBase SIMD types as own)#43
Merged
Merged
Conversation
Aqua deps_compat requires every dep (including stdlibs in [extras]) to have a compat bound. Adds `Test = "1"` to resolve the failure surfaced in JuliaSIMD downstream Interface CI. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
SLEEFPirates intentionally extends Base operators (^, sinh, tanh, etc.) on VectorizationBase's SIMD types — this is the standard pattern in the JuliaSIMD ecosystem and is not type piracy in intent. Pass `treat_as_own = [AbstractSIMD, Vec, MM, VecUnroll]` so Aqua.test_all no longer flags these methods. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two pre-existing Aqua hygiene failures on master CI that surface in JuliaSIMD/VectorizationBase.jl#127 / #128's downstream Interface checks:
Aqua.test_deps_compat:Testis in[extras]/[targets]but lacks a[compat]entry. AddTest = "1".Aqua.test_piracies: Flags the^,sincospi,sinh/cosh/tanh/asinh/acosh/atanh,log1p,expm1methods this package defines onVectorizationBase.{AbstractSIMD, Vec, MM, VecUnroll}. These are intentional — SLEEFPirates exists to extendBasemath functions to those VectorizationBase types and is maintained alongside VectorizationBase. UseAqua.test_all(SLEEFPirates; piracies = (treat_as_own = [...]),)to suppress the false positive.treat_as_ownuses===membership (not<:), so each individual type must be listed —MM <: AbstractSIMDdoesn't transitively cover it.Test plan
Aqua.test_deps_compat(SLEEFPirates)passes locally.Aqua.test_piracies(SLEEFPirates; treat_as_own = [AbstractSIMD, Vec, MM, VecUnroll])passes locally.Aqua.test_all(SLEEFPirates; ...)11/11 pass (was 9/11).Out of scope
The
accuracy asinh/sin/cos/tan/...Float32 numerical regressions are tracked separately — different failure mode, different fix area.🤖 Generated with Claude Code