Add missing [compat] entries to fix Aqua deps_compat#34
Merged
Conversation
Adds compat bounds for stdlib deps (Distributed, Random) and for the test-only extras (RNGTest, StaticArrays, Test) so that Aqua.test_deps_compat passes. Without these, downstream CI (e.g. VectorizationBase.jl Interface tests) failed on the deps_compat check. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aqua.test_deps_compat(VectorizedRNG)fails on current CI because several deps in[deps](stdlibs) and[extras]lack[compat]entries:Distributed(stdlib,[deps])Random(stdlib,[deps])Test,RNGTest,StaticArrays([extras])Add
"1"compat for each (RNGTest only has 1.x in the General registry).This is the same kind of pre-existing Aqua hygiene failure that's been failing the VectorizationBase.jl downstream
VectorizedRNG.jl/Interface/{1,lts,pre}jobs for a while. Posting separately so the macOS-ARM grant work I'm doing in JuliaSIMD/VectorizationBase.jl#127 / #128 doesn't get tangled up with it.Test plan
Aqua.test_deps_compat(VectorizedRNG)passes locally.Aqua.test_all(VectorizedRNG)passes all checks: ambiguities, unbound type params, undefined exports, project_extras vs test/Project.toml, stale deps, compat (4), piracies, persistent tasks.🤖 Generated with Claude Code