Skip to content

fully qualify promote_eltypeof call #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2023
Merged

fully qualify promote_eltypeof call #411

merged 1 commit into from
Jul 12, 2023

Conversation

vtjnash
Copy link
Contributor

@vtjnash vtjnash commented Jul 12, 2023

Missed in #407, but causing doctest build to fail when we try to use this.

Missed in #407, but causing doctest build to fail when we try to use this.
@vtjnash vtjnash added the merge me Merge when all tests are passing label Jul 12, 2023
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #411 (78b1321) into main (c93589c) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #411   +/-   ##
=======================================
  Coverage   93.84%   93.84%           
=======================================
  Files          12       12           
  Lines        7521     7521           
=======================================
  Hits         7058     7058           
  Misses        463      463           
Impacted Files Coverage Δ
src/sparsevector.jl 95.50% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ViralBShah
Copy link
Member

Please merge if ready.

@vtjnash vtjnash merged commit b4d4498 into main Jul 12, 2023
@vtjnash vtjnash deleted the jn/better-cat-fix branch July 12, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Merge when all tests are passing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants