Skip to content

feat(auth): implement rate limiting for authentication endpoints #872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Devsol-01 wants to merge 1 commit into
base: main
Choose a base branch
from
+214 −78
Open

feat(auth): implement rate limiting for authentication endpoints #872

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions contracts/vault/src/emergency.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,10 @@ pub fn read_proposal(env: &Env, id: u32) -> Option<EmergencyProposal> {
}

pub fn write_proposal(env: &Env, id: u32, proposal: &EmergencyProposal) {
env.storage()
.instance()
.set(&DataKey::Emergency(EmergencyStorageKey::Proposal(id)), proposal);
env.storage().instance().set(
&DataKey::Emergency(EmergencyStorageKey::Proposal(id)),
proposal,
);
}

pub fn next_proposal_id(env: &Env) -> u32 {
Expand All @@ -70,9 +71,10 @@ pub fn next_proposal_id(env: &Env) -> u32 {
.get(&DataKey::Emergency(EmergencyStorageKey::ProposalNonce))
.unwrap_or(0);
let next = nonce.checked_add(1).expect("proposal nonce overflow");
env.storage()
.instance()
.set(&DataKey::Emergency(EmergencyStorageKey::ProposalNonce), &next);
env.storage().instance().set(
&DataKey::Emergency(EmergencyStorageKey::ProposalNonce),
&next,
);
next
}

Expand Down Expand Up @@ -153,7 +155,6 @@ pub fn simulate_emergency_unwind(
#[cfg(test)]
mod tests {
use super::*;
use soroban_sdk::testutils::Address as _;

#[test]
fn test_distinct_approvers_required() {
Expand Down
Loading
Loading