perf: IDOT_TEAM=1 fuses three OpenMP regions into one team per expert… - #1397
Open
KyleSanderson wants to merge 1 commit into
Open
KyleSanderson wants to merge 1 commit into
KyleSanderson wants to merge 1 commit into
Conversation
… forward Eliminates 2x team barrier spin (gomp_team_barrier_wait_end + gomp_barrier_wait_end) per expert forward. VTune measured 168.3 CPU-s of OpenMP imbalance/serial spin. A/B test on GLM-5.2 real workload (--ram 8): prefill: 73.17s -> 71.20s (-2.7%) decode: 75.20s -> 62.07s (-17.5%) No regression in expert-matmul IPC or output correctness. Perf c2c confirmed no material false sharing (max HITM 2.15%).
Owner
|
Status: every Linux and ARM job is red on this branch (13 of 26 checks), including the token-exact oracles, so it cannot be reviewed for the speed claim yet. The change itself is opt-in and looks numerically neutral (same per-element arithmetic, collapse(2) over the same loops), so the failures are probably the build or a stale base: please rebase onto dev and look at one red log. With CI green, the number I would need is an A/B on one binary (IDOT_TEAM=0 vs 1, same prompt, tok/s), since the getenv sits on a per-call path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
perf: IDOT_TEAM=1 fuses three OpenMP regions into one team per expert forward
Eliminates 2x team barrier spin (gomp_team_barrier_wait_end + gomp_barrier_wait_end)
per expert forward. VTune measured 168.3 CPU-s of OpenMP imbalance/serial spin.
A/B test on GLM-5.2 real workload (--ram 8):
prefill: 73.17s -> 71.20s (-2.7%)
decode: 75.20s -> 62.07s (-17.5%)
No regression in expert-matmul IPC or output correctness.
Perf c2c confirmed no material false sharing (max HITM 2.15%).
Validation
make -C c checkmake -C c cuda-test(if applicable)Compatibility