Skip to content

Conversation

@K-dash
Copy link
Owner

@K-dash K-dash commented Nov 16, 2025

Summary

  • Introduced UserOAuthProvider to facilitate the reuse of refresh tokens generated by the CLI's user-oauth flow in Python.
  • Implemented methods for loading OAuth2 refresh tokens from a shared credentials file, improving user experience for end-user scenarios.
  • Added tests to validate the functionality of UserOAuthProvider, ensuring correct behavior when loading tokens and handling errors.
  • Updated documentation to reflect the new OAuth2 capabilities, including usage examples for both CLI and Python SDK.
  • Enhanced the NblmClient to support creating instances with UserOAuthProvider, streamlining the integration of user authentication in applications.

Testing

  • Pre-commit hooks passed (automatically checked on commit)

Additional Context

… functionality

- Introduced UserOAuthProvider to facilitate the reuse of refresh tokens generated by the CLI's user-oauth flow in Python.
- Implemented methods for loading OAuth2 refresh tokens from a shared credentials file, improving user experience for end-user scenarios.
- Added tests to validate the functionality of UserOAuthProvider, ensuring correct behavior when loading tokens and handling errors.
- Updated documentation to reflect the new OAuth2 capabilities, including usage examples for both CLI and Python SDK.
- Enhanced the NblmClient to support creating instances with UserOAuthProvider, streamlining the integration of user authentication in applications.
@codecov
Copy link

codecov bot commented Nov 16, 2025

Codecov Report

❌ Patch coverage is 94.44444% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
crates/nblm-core/src/auth/oauth/mod.rs 94.33% 6 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
+ Coverage   87.56%   88.30%   +0.74%     
==========================================
  Files          40       40              
  Lines        5043     5149     +106     
==========================================
+ Hits         4416     4547     +131     
+ Misses        627      602      -25     
Flag Coverage Δ
rust 88.30% <94.44%> (+0.74%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crates/nblm-cli/src/util/oauth_bootstrap.rs 62.43% <100.00%> (+0.41%) ⬆️
crates/nblm-core/src/auth/oauth/mod.rs 92.45% <94.33%> (+0.74%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@K-dash K-dash merged commit 562fdac into main Nov 16, 2025
17 checks passed
@K-dash K-dash deleted the feature/python-oauth-support branch November 16, 2025 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants