Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #1009

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Conversation

updates:
- [github.com/pre-commit/pre-commit-hooks: v4.6.0 → v5.0.0](pre-commit/pre-commit-hooks@v4.6.0...v5.0.0)
- [github.com/pre-commit/mirrors-clang-format: v17.0.6 → v19.1.1](pre-commit/mirrors-clang-format@v17.0.6...v19.1.1)
- [github.com/PyCQA/pylint: v3.2.7 → v3.3.1](pylint-dev/pylint@v3.2.7...v3.3.1)
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from fa3d41d to c392d77 Compare October 7, 2024 23:28
@dantti
Copy link
Member

dantti commented Oct 8, 2024

@winterz seems clang-format v19 still has some issues, as it wants to add spaces around -> is this fine in our CI or maybe it didn't run on all files?

@winterz
Copy link
Member

winterz commented Oct 9, 2024

I'll reopen the clang-format bug

@winterz
Copy link
Member

winterz commented Oct 9, 2024

ah! we forgot to add StatementAttributeLikeMacros: [emit] to the .clang-format file
I added that setting in d99cdd9cb4ffff2479aa1fff327e3b6e502de888

try again

@dantti
Copy link
Member

dantti commented Oct 9, 2024

pre-commit.ci run

@dantti
Copy link
Member

dantti commented Oct 9, 2024

it seems most changes are real fixes now

@dantti dantti merged commit 22a3db4 into 3.1 Oct 9, 2024
18 checks passed
@dantti dantti deleted the pre-commit-ci-update-config branch October 9, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants