Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Add CLAZY_CHECKS and CLAZY_IGNORE_DIRS env vars #280

Merged
merged 1 commit into from
Jan 14, 2024
Merged

CI: Add CLAZY_CHECKS and CLAZY_IGNORE_DIRS env vars #280

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ on:
schedule:
- cron: '0 3 * * *'

env:
CLAZY_CHECKS: "level2,no-qstring-allocations,no-fully-qualified-moc-types"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://invent.kde.org/sdk/clazy/-/merge_requests/111 just landed so we don't need to exclude fully-qualified-moc-types anymore -- assuming you can somehow make CI use the latest clazy from git master.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use distro packages, if there were prebuilt clazy would likely be easy, we can also compile it here if you think it's worth it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the low amount of development on KDSoap, it's fine to exclude it until the distro has a fixed clazy.

CLAZY_IGNORE_DIRS: ".*libkode.*"

jobs:
build:
runs-on: ${{ matrix.os }}
Expand Down