Add QBrush support #862
Open
Add QBrush support #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahayzen-kdab
reviewed
Mar 1, 2024
|
|
||
| #[repr(C)] | ||
| pub struct QBrush { | ||
| _cspec: MaybeUninit<usize>, |
There was a problem hiding this comment.
valgrind isn't happy about something, maybe something is still incorrect?
There was a problem hiding this comment.
yep :) I try to make it working on local here.
There was a problem hiding this comment.
No idea where is the problem...
we have "'using DataPtr = std::unique_ptr<QBrushData, QBrushDataPointerDeleter>;"
which is a _cspec: MaybeUninit,
but valgrind found a memory leak...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.