WIP: qtypes: add support for Qt alias types that don't match #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahayzen-kdab
commented
Mar 28, 2024
| } | ||
|
|
||
| #[repr(C)] | ||
| pub struct QInt64 { |
There was a problem hiding this comment.
should probably have things like Eq, Ord, Debug ?
Or do we change this to be a totally trivial type?
There was a problem hiding this comment.
As could this just be QInt64(i64) ?
ahayzen-kdab
force-pushed
the
882-add-qtypes
branch
from
e8826f5
to
e409d32
Compare
Montel
reviewed
Mar 29, 2024
| @@ -0,0 +1,83 @@ | |||
| // SPDX-FileCopyrightText: 2023 Klarälvdalens Datakonsult AB, a KDAB Group company <[email protected]> | |||
| alignof(::std::int64_t), | ||
| sizeof(::std::int64_t)); | ||
|
|
||
| // static_assert(!::std::is_trivially_copy_assignable<qsizetype>::value); |
| @@ -0,0 +1,29 @@ | |||
| // clang-format off | |||
| // SPDX-FileCopyrightText: 2023 Klarälvdalens Datakonsult AB, a KDAB Group company <[email protected]> | |||
Some times don't match the Rust types so add these missing types. Closes KDAB#882
ahayzen-kdab
force-pushed
the
882-add-qtypes
branch
from
e409d32
to
e5daff8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #904 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 73 73
Lines 12484 12484
=========================================
Hits 12484 12484 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #882