Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement QAnyStringView #995

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Implement QAnyStringView #995

merged 1 commit into from
Oct 4, 2024

Conversation

redstrate
Copy link
Contributor

This is a read-only string type that's used in several new Qt6 APIs such as QQmlApplicationEngine::loadFromModule.

Fixes #629

@redstrate redstrate self-assigned this Jul 9, 2024
redstrate
redstrate commented Jul 9, 2024
View reviewed changes
crates/cxx-qt-lib/build.rs Outdated Show resolved Hide resolved
LeonMatthesKDAB
LeonMatthesKDAB requested changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@LeonMatthesKDAB LeonMatthesKDAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @redstrate , thanks for working on this!
It can hopefully really improve some of the Rust-C++ string interop 🤞

For now, some initial comments, that you may already be aware of.
If you think this PR isn't ready for review yet, also consider converting it to a draft under the "reviewers" section.

crates/cxx-qt-lib/src/core/qanystringview.rs Outdated Show resolved Hide resolved
crates/cxx-qt-lib/src/core/qanystringview.rs Outdated Show resolved Hide resolved
crates/cxx-qt-lib/src/core/qanystringview.rs Outdated Show resolved Hide resolved
crates/cxx-qt-lib/src/core/qanystringview.rs Outdated Show resolved Hide resolved
crates/cxx-qt-lib/src/core/qanystringview.rs Outdated Show resolved Hide resolved
crates/cxx-qt-lib/src/core/qanystringview.rs Show resolved Hide resolved
crates/cxx-qt-lib/src/core/qanystringview.cpp Outdated Show resolved Hide resolved
@redstrate redstrate force-pushed the work/josh/qanystringview branch 3 times, most recently from 0dc4e83 to 1ef4fe2 Compare July 18, 2024 17:02
@redstrate redstrate force-pushed the work/josh/qanystringview branch 6 times, most recently from 8622385 to 6243813 Compare August 4, 2024 23:35
@codecov Codecov
Copy link

codecov bot commented Aug 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ff27740) to head (cc4646d).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #995   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           71        71           
  Lines        11928     11928           
=========================================
  Hits         11928     11928

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ahayzen-kdab
ahayzen-kdab previously approved these changes Aug 15, 2024
View reviewed changes
Copy link
Collaborator

@ahayzen-kdab ahayzen-kdab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, lets see what Leon thinks when he is back

LeonMatthesKDAB
LeonMatthesKDAB previously approved these changes Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@LeonMatthesKDAB LeonMatthesKDAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@LeonMatthesKDAB
Copy link
Collaborator

@redstrate The changes to the assert_alignment_and_size macro have broken the rebase. Can you please update the check :)

@LeonMatthesKDAB LeonMatthesKDAB dismissed stale reviews from ahayzen-kdab and themself via f7d4d31 October 4, 2024 07:43
@LeonMatthesKDAB LeonMatthesKDAB force-pushed the work/josh/qanystringview branch 2 times, most recently from f7d4d31 to 9213d75 Compare October 4, 2024 07:43
@redstrate @LeonMatthesKDAB
Implement QAnyStringView
cc4646d 
This is a read-only string type that's used in several new Qt6 APIs such
as QQmlApplicationEngine::loadFromModule.

Fixes KDAB#629
@LeonMatthesKDAB
Copy link
Collaborator

I've updated this PR, hopefully it passes CI now 🤞

ahayzen-kdab
ahayzen-kdab approved these changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@ahayzen-kdab ahayzen-kdab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

@ahayzen-kdab ahayzen-kdab merged commit f366fcb into KDAB:main Oct 4, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahayzen-kdab ahayzen-kdab ahayzen-kdab approved these changes

@LeonMatthesKDAB LeonMatthesKDAB LeonMatthesKDAB left review comments

Assignees

@redstrate redstrate

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cxx-qt-lib bindings for QAnyStringView
3 participants
@redstrate @LeonMatthesKDAB @ahayzen-kdab