[No QA] Remove unsafe type assertions from ReportSecondaryActionUtilsTest.ts#1
[No QA] Remove unsafe type assertions from ReportSecondaryActionUtilsTest.ts#1KJ21-ENG wants to merge 10000 commits into
Conversation
…-visibility Docs updates for E/A#94698 clarify For you section hidden for new users
…anual-reimbursement [No QA] Docs updates for E/A#92787 Authorized payer for manual reimbursement
…tch-4 [No QA] Update Concierge-Intelligence to remove exposed template bit
…f-44e2-8820-bef92bd1f751-94739-optionslistutilstest.tsx [No QA] Remove unsafe type assertions from OptionsListUtilsTest.tsx tests
…a-4ecf-a452-d6f62b7d3c71-94739-reportprimaryactionutilstest.ts [No QA] Remove unsafe type assertions from ReportPrimaryActionUtilsTest.ts tests
…rPhaseSetStateWarning Co-authored-by: DylanDylann <DylanDylann@users.noreply.github.com>
…per localization of report names across various components.
…ion for display names in tooltips. Adjusted related components to utilize the new translation feature, improving user experience in reports and IOU request
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
# Conflicts: # config/eslint/eslint.seatbelt.tsv
…early stack reset
…-short-mentions-scan perf: share scans across useShortMentionsList instances
eslint-config-expensify 4.0.7 added 'notation' to the rule's exception list, so buildDotNotationPath is no longer flagged and the directive became an unused-directive lint error on main. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Allow re-verifying an already-validated domain for non-admin domain members instead of showing a NotFoundPage page
…ed-eslint-disable [No QA] Remove unused eslint-disable for no-negated-variables
…les-import-category-validation Skip non-existent categories when importing merchant rules from spreadsheet
fix: Prevent "Maximum update depth exceeded" crash when selecting the same workspace while creating consecutive reports
fix: Message, sent in a new chat, displayed in the compose box after opening
…ecurityCopy Replace user-facing "Magic code" copy with "Security code"
refactor getWorkspaceIcon to use translate from useLocalize
…ic-code-navigates-back-payment-v2 Fix magic code navigates back on payment (SettlementButton) v2
…rover [Payment due @marufsharifi] [CP Staging] Stop nudging approvers to submit reports
…entalHelpDoc [No QA] Remove rental cars from Consolidated Travel Billing help doc
…evice-occlusion-safety [No QA] Update Agent Device interaction safety instructions
workspaceSection capped width unconditionally, cutting the rules list narrower than before on layouts wider than workspaceSection but still narrow (mWeb/tablet ~713-800px). Use workspaceSectionMobile there, matching PolicyRulesPage's existing pattern.
Co-authored-by: Aimane Chnaif <aimane-chnaif@users.noreply.github.com>
…firm-hidden-currency [Copy Workspace Settings] Fix hidden currency in copy settings
…droidAuthToken Fix QBO connect on Android by authenticating the native setup WebView
…ulesScrollbar Fix scrollbar position on Rules Agents tab when rules exist
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Closing this malformed draft: it targeted the stale fork main and displayed unrelated history. The clean one-commit branch will be published against Expensify/App main. |
Explanation of Change
Removed
@typescript-eslint/no-unsafe-type-assertionviolations fromtests/unit/ReportSecondaryActionUtilsTest.tsas part of the cleanup for Expensify/App issue Expensify#94739.What changed:
Report,Policy, andTransactionassertions withcreateMock<T>.anycasts with typed mock definitions.jest.mockedfor theisPolicyAdminmocks.Why this approach is safe:
Reviewer focus:
Fixed Issues
$ Expensify#94739
PROPOSAL: Expensify#94739 (comment)
Count change
Current baseline source:
config/eslint/eslint.seatbelt.tsvBefore:
tests/unit/ReportSecondaryActionUtilsTest.ts: 31 violationsAfter:
tests/unit/ReportSecondaryActionUtilsTest.ts: 0 violationsNet reduction:
@typescript-eslint/no-unsafe-type-assertionviolations.TSV evidence:
Tests
npm run lint -- --show-warnings tests/unit/ReportSecondaryActionUtilsTest.ts
CI=true npm run lint -- --no-cache --show-warnings tests/unit/ReportSecondaryActionUtilsTest.ts
npm run test -- tests/unit/ReportSecondaryActionUtilsTest.ts
The focused Jest suite passed all 165 tests. Focused lint, formatting, TSV restoration, and diff hygiene also passed.
Offline tests
Not applicable: this test-only cleanup adds no network behavior.
QA Steps
Not applicable: production behavior and UI are unchanged.
PR Author Checklist
Screenshots/Videos
Not applicable: only a unit-test source file changed.