[PR] Address identified bugs and request received during Internal Test (1.4.2)#38
Merged
doyoonkim3312 merged 15 commits intoreleasefrom Jun 22, 2025
Merged
[PR] Address identified bugs and request received during Internal Test (1.4.2)#38doyoonkim3312 merged 15 commits intoreleasefrom
doyoonkim3312 merged 15 commits intoreleasefrom
Conversation
- Add missing dependency (UI Tooling for Jetpack Compose)
- Remove duplicated icon from the Push notification sent via FCM (Remove optional Large Icon)
- Add necessary string resources for localizing title text to be shown over Push Notification.
- Change the format of title text on the Push notification, alongside with a proper localization.
- Custom-defined WheelPicker based TimePicker Composable.
- Add necessary string resources for localization - Add Theme value for Gray-based container color.
- Wheel Spinner based Time Picker has been defined. - This component has been applied to the EditBookmarkScreen to enhance user experiences in selecting time for reminder options.
- Remove redundant bottom paddings.
- Isolate Time Picker from the DateTimePicker to enhance user experience. - Migrated from type-based date selection to selection based date selection.
- Modify logic for handling date and time information for reminder option.
…imePicker
- Replace legacy DateTimePicker (type-based selection) to Improved DatePicker and TimePicker.
* Each DatePicker and TimePicker would be displayed over Dialog that covers entire composable behind it.
* Wheel-spinner based time selection has been applied.
- Change manual dialog popup to Dialog composable.
- Fix height value for Top and Bottom spacer at the Wheel Spinner, - Add Spacer at the bottom of the Dialog for better appearance.
…tification title
- Change the condition for determining localized notice name.
* Received strings have been identified as Korean title.
Member
Author
|
Ignore build result of GitHub Action. (Failed on GitHub Action). Project has been built and verified on local-side machine. |
- Add missing color properties to the text under TimePicker Dialog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identified bugs and request received during internal testing have been addressed.