Merged
Conversation
- Finalize Application Color Theme for Container Background.
* Start Destination of Each Graph
containerBackgroundSolid
* Other destinations
displayBackground
- Dynamic background color is being applied to the Scaffold and TopAppBar corresponding to the destination.
- Ally finalized background color theme for better appearance.
- Apply appropriate transition on navigation.
- Theme Color Modification (in-progress)
- Separate Scaffold (in-progress)
- Theme Color Scheme has been finalized (Jun 24, 2025)
(https://knutice.atlassian.net/wiki/spaces/KNUTICE/pages/1736705)
- Apply finalized theme color scheme to globally shared composable under :common.
- Decentralization fo Top-level centralized scaffold.
* Each Screen would now have their own Scaffold.
* HomeScreen & BookmarkListScreen would have a shared Scaffold defined under MainActivity to handle navigation triggered by BottomNavBar.
- Add globally used pre-defined TopAppBar Comopsable to increase efficiency. * TopAppBar would have a title text and pre-defined 'back button' with Backward Arrow Icon.
- Centralized TopAppBar has been decentralized from the Shared Scaffold.
* Each Home and BookmarkListScreen would now have their own TopAppBar.
* Globally used TopAppBar (TopAppBarWithActions) has been defined under :common.
* Duplicated Top Padding has been removed.
- Additional arguments (listeners for button under TopAppBar actions) have been provided. - Missing UI attributes have been applied.
- Missing UI attributes have been applied to the Composable located under TopBar section.
- Remove Centralized TopAppBar under Top-Level Shared Scaffold.
- Replace misplaced Modifier Instance to modifier instance provided over argument.
- Missing UI Configurations have been applied.
Member
Author
|
Bypass Github action for acknowledged issue on Test code. (Unexpected annotation related issue) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UI Improvements have been made.