Comparisons: Enable safe mixed integer shortcut helpers#2
Open
KRRT7 wants to merge 3 commits into
Open
Conversation
f4f292b to
28ca634
Compare
Limit mixed-type result inversion to helper families where the inverse comparison is semantically safe and generated accordingly. This keeps float comparisons on their direct helpers because NaN makes ordered comparisons non-complementary. Keep the Python2 LONG_INT GT/GE/NE generated helpers because dual NILONG helpers still depend on their internal LONG_CLONG implementations, while enabling shortcut generation for INT_CLONG helpers.
Restricts the PyObject*/CTypeCLong inversion path to tshape_int and tshape_long, making the allowed inversion domain explicit and preventing any future non-integer shape routed through CTypeCLong from bypassing the NaN/complement protections.
440502b to
f8bf3b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Property-based exploration
I used
crosshair-toolandhypothesisintests/scratch/to check which comparison inversions are unsafe.CrossHair found NaN counterexamples for scalar float and tuple comparisons:
Examples found:
Hypothesis found minimized counterexamples, including the list case:
Minimized examples:
These support keeping inversion restricted to comparison families where complement inversion is valid.
Testing
Python 2.7.18 validation passed after disabling local LTO/ccache because the default macOS toolchain had an unrelated LLVM bitcode linker mismatch.