Wrap whole upload route in try-catch

KSET · May 20, 2020 · 48a8b55 · 48a8b55
1 parent 772ed1c
commit 48a8b55
Showing 1 changed file with 26 additions and 25 deletions.
diff --git a/api/routes/image/upload.js b/api/routes/image/upload.js
@@ -32,7 +32,8 @@ const imageSizes = [ 80, 160, 240, 320, 400, 480, "default" ];
 router.use(requireAuth());
 
 router.post("/", async (req, res) => {
-  const { file } = req.files;
+  let files = {};
+
   const error = (message, data = {}) => {
     res.status(415);
 
@@ -46,38 +47,38 @@ router.post("/", async (req, res) => {
     });
   };
 
-  if (!file) {
-    return error("No file provided");
-  }
+  try {
+    const { file } = req.files;
 
-  const ext = extensionMap[file.mimetype];
+    if (!file) {
+      return error("No file provided");
+    }
 
-  if (!ext) {
-    return error(`Invalid file type. Only ${ Object.values(extensionMap).map((ext) => `.${ ext }`).join(", ") } supported.`, {
-      mimeType: file.mimetype,
-    });
-  }
+    const ext = extensionMap[file.mimetype];
 
-  const id = `image-${ i++ }`;
-  const dir = joinPath(process.cwd(), "uploads", id);
+    if (!ext) {
+      return error(`Invalid file type. Only ${ Object.values(extensionMap).map((ext) => `.${ ext }`).join(", ") } supported.`, {
+        mimeType: file.mimetype,
+      });
+    }
 
-  await mkdir(dir, { recursive: true });
+    const id = `image-${ i++ }`;
+    const dir = joinPath(process.cwd(), "uploads", id);
 
-  const fileUploadName =
-    (name) =>
-      Number.isInteger(name)
-      ? `w${ name }.${ ext }`
-      : `${ name }.${ ext }`
-  ;
+    await mkdir(dir, { recursive: true });
 
-  const fileUploadPath =
-    (name) =>
-      joinPath(dir, fileUploadName(name))
-  ;
+    const fileUploadName =
+      (name) =>
+        Number.isInteger(name)
+        ? `w${ name }.${ ext }`
+        : `${ name }.${ ext }`
+    ;
 
-  let files = {};
+    const fileUploadPath =
+      (name) =>
+        joinPath(dir, fileUploadName(name))
+    ;
 
-  try {
     if ("gif" === ext) {
       const filePath = fileUploadPath("default");