Lint and format #408
Open
Lint and format #408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SohierDane
requested review from
bovard,
jhtschultz and
lipovetz
and removed request for
jhtschultz
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Results of running
ruff format&ruff check --fix, with no other changes.We already discussed and rejected the idea of linting and formatting this repo three weeks ago in order to prevent a merge conflict for Werewolf. However, given that their PR has been open since July and might not be merged for some time yet, I'd like to revisit the issue. I'd like to get as much work done on this codebase as I can before Werewolf launches to limit the tech debt / constraints that will be imposed by a new live game. For example, it may only be feasible to migrate to Gymnasium 1.2 before Werewolf is live. This will unfortunately mean accepting some degree of merge conflicts.
In this specific case, it should be quite straightforward to resolve the conflicts by running
ruff format . && ruff check --fixin the werewolf branch before merging.