Skip to content

refactor(processor-builder): apply readonly property to enhance immut… #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2024
Merged

refactor(processor-builder): apply readonly property to enhance immut… #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 26 additions & 10 deletions src/ProcessorBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,32 +11,48 @@

class ProcessorBuilder
{
public function __construct(private ProcessorRegistry $registry)
public function __construct(private readonly ProcessorRegistry $registry)
{
}

public function build(string $context, string $name, array $config = []): Processor
public function build(string $context, string $name, array $processorConfig = []): Processor
{
$processor = $this->registry->get($context, $name);
if ($processor instanceof ConfigurableProcessor && !empty($config)) {
$processor->configure($config);
if ($processor instanceof ConfigurableProcessor && !empty($processorConfig)) {
$processor->configure($processorConfig);
}

return $processor;
}

/**
* @param array<int|string, string|array<string, mixed>> $processorSpecs
*/
public function buildPipeline(string $context, array $processorSpecs): Pipeline
{
$pipeline = new ProcessorPipeline();
foreach ($processorSpecs as $name => $config) {
if (is_int($name)) {
$name = $config;
$config = [];
}
$processor = $this->build($context, $name, $config);
foreach ($processorSpecs as $key => $spec) {
$processorName = $this->resolveProcessorName($key, $spec);
$processorConfig = $this->resolveProcessorConfig($key, $spec);
$processor = $this->build($context, $processorName, $processorConfig);
$pipeline->addProcessor($processor);
}

return $pipeline;
}

private function isUnnamedProcessor(int|string $key): bool
{
return is_int($key);
}

private function resolveProcessorName(int|string $key, string|array $spec): string
{
return $this->isUnnamedProcessor($key) ? (string) $spec : (string) $key;
}

private function resolveProcessorConfig(int|string $key, string|array $spec): array
{
return $this->isUnnamedProcessor($key) ? [] : (array) $spec;
}
}
Loading