Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37402 - add jquery-ui dependency #10982

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MariaAga
Copy link
Contributor

@MariaAga MariaAga commented May 2, 2024

we want to remove it in core since its no longer used theforeman/foreman#10142
so adding it here as only Katello seem to use it, and hopefully it will be removed here as well

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an OK stopgap to me. Did you have a look at how many work it would be to actually drop it from Katello too?

@MariaAga
Copy link
Contributor Author

MariaAga commented May 2, 2024

yeah its used in some parts of the sync management (and maybe more, I didn't look after that). and I dont have capacity now to try to remove it from there since its spread through a few files

@ekohl
Copy link
Member

ekohl commented May 2, 2024

Sounds good to me: the Katello team has plans to remove those pages anyway. It may be a waste of time trying to rework them just to drop jquery-ui while they're fully replaced soon after.

@jeremylenz
Copy link
Member

Sync management is special, though, since it's actually ERB + vanilla JS + jQuery and doesn't have any Angular in it 😳

@MariaAga
Copy link
Contributor Author

MariaAga commented May 8, 2024

@jeremylenz Can we move jquery-ui to katello anyway? and makes plans to maybe refactor sync management later?

@jeremylenz
Copy link
Member

@MariaAga If we're the only ones that use it, I'm fine with moving it to Katello for now. And yes we should also talk about redesigning sync status :)

@sjha4
Copy link
Member

sjha4 commented May 8, 2024

Wondering if this: https://bugzilla.redhat.com/show_bug.cgi?id=2274132 has anything to do with this change here and if it fixes this.

@jeremylenz
Copy link
Member

@sjha4 The Foreman PR dropping it is not yet merged, so my guess is it's something else 🤷

@MariaAga
Copy link
Contributor Author

is anything else needed for this pr?

@m-bucher
Copy link
Contributor

m-bucher commented Jul 3, 2024

is anything else needed for this pr?

This will also require moving the dependency in https://github.com/theforeman/foreman-packaging from foreman to rubygem-katello package.
I assume it would be nice to have that prepared in a PR there as well 😉 .

Once that is done I guess it is only a matter of who is willing and allowed to push the buttons 😄

@MariaAga
Copy link
Contributor Author

@m-bucher Thanks, added it: theforeman/foreman-packaging#11004

Copy link
Member

@ianballou ianballou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks perfectly fine from a Katello standpoint. Waiting on https://github.com/theforeman/foreman-packaging/pull/11004/files to merge before merging this. Please ping us when the packaging PR and Foreman PRs are ready.

@ianballou
Copy link
Member

A rebase will be needed to get the tests green.

@ianballou
Copy link
Member

@MariaAga looks like there's a conflict now with katello.gemspec. Feel free to ping me when the time to merge is right so we can do it quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants