-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #37852 - Support Rails 7.0 #11155
base: master
Are you sure you want to change the base?
Conversation
4f91a1c
to
1ac6a68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see lots of changes around the error handling and I think that's already Rails 6.1 compatible. Perhaps something that we can already merge to reduce the size of this PR?
@@ -63,7 +63,7 @@ def setup | |||
|
|||
@validator.validate(@content_facet) | |||
|
|||
assert_empty @content_facet.errors.values | |||
assert_empty @content_facet.errors.map { |error| error.message } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assert_empty @content_facet.errors.map { |error| error.message } | |
assert_empty @content_facet.errors.map(&:message) |
@SatelliteQE/TeamPhoenix |
PRT Result
|
PRT Result
|
@chris1984 I doubt PRT is going to be of any use. You need updated Foreman and Rails and we haven't packaged that. |
1ac6a68
to
b806bb1
Compare
6969ab8
to
b26b87d
Compare
b26b87d
to
1f31c0f
Compare
The test failure is unrelated to this PR, it for some reason wasn't caught by GHA for theforeman/foreman_remote_execution#913 |
What are the changes introduced in this pull request?
We're updating Rails version in Foreman: theforeman/foreman#10299 (please visit it first if you have any questions/suggestions, there are many comments regarding the changes)
This PR tries to make Katello Rails 7 friendly (compatible).
Considerations taken when implementing this change?
#<<
for ActiveModel::Errors objectsWhat are the testing steps for this pull request?
Ensuring CI is green.
If you really want some 🍪, test some workflows live.