Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37852 - Support Rails 7.0 #11155

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ofedoren
Copy link
Contributor

@ofedoren ofedoren commented Sep 20, 2024

What are the changes introduced in this pull request?

We're updating Rails version in Foreman: theforeman/foreman#10299 (please visit it first if you have any questions/suggestions, there are many comments regarding the changes)

This PR tries to make Katello Rails 7 friendly (compatible).

Considerations taken when implementing this change?

  1. Mostly removing deprecated usage of #<< for ActiveModel::Errors objects
  2. Just a heads up regarding https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#digest-class-for-activesupport-digest-changing-to-sha256. How it affects this plugin is more or less here: Fixes #37825 - Upgrade Rails to 7.0 theforeman/foreman#10299 (comment)

What are the testing steps for this pull request?

Ensuring CI is green.

If you really want some 🍪, test some workflows live.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see lots of changes around the error handling and I think that's already Rails 6.1 compatible. Perhaps something that we can already merge to reduce the size of this PR?

@@ -63,7 +63,7 @@ def setup

@validator.validate(@content_facet)

assert_empty @content_facet.errors.values
assert_empty @content_facet.errors.map { |error| error.message }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
assert_empty @content_facet.errors.map { |error| error.message }
assert_empty @content_facet.errors.map(&:message)

@chris1984
Copy link
Member

@SatelliteQE/TeamPhoenix

@Satellite-QE
Copy link

PRT Result

Build Number: 9132
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman --team Phoenix-content --external-logging
Test Result: = 6 skipped, 3973 deselected, 5492 warnings, 1490 errors in 4906.50s (1:21:46) =

@Satellite-QE
Copy link

PRT Result

Build Number: 9133
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman --team Phoenix-subscriptions --external-logging
Test Result: ======= 4779 deselected, 5492 warnings, 690 errors in 4923.46s (1:22:03) =======

@ekohl
Copy link
Member

ekohl commented Oct 24, 2024

@chris1984 I doubt PRT is going to be of any use. You need updated Foreman and Rails and we haven't packaged that.

@ofedoren ofedoren force-pushed the feat-37852-support-rails-7 branch 2 times, most recently from 6969ab8 to b26b87d Compare November 7, 2024 14:24
@ofedoren
Copy link
Contributor Author

ofedoren commented Nov 7, 2024

The test failure is unrelated to this PR, it for some reason wasn't caught by GHA for theforeman/foreman_remote_execution#913

Fixed in theforeman/foreman_remote_execution#925

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants