Fixes #37923 - Set HTTP proxy as default after creating #11183
+62
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stejskalleos is this ready to be pulled out of draft state? |
|
@chris1984 not yet, I need to update Jira tickets first and check if I haven't forgot something |
ShimShtein
reviewed
Nov 6, 2024
stejskalleos
force-pushed
the
ls/default_http
branch
from
a288ef2
to
3102a6f
Compare
|
@chris1984 @ShimShtein ready for review, together with theforeman/foreman#10372 |
ofedoren
reviewed
Nov 11, 2024
app/controllers/katello/concerns/api/v2/http_proxies_controller_extensions.rb
Outdated
Show resolved
Hide resolved
stejskalleos
force-pushed
the
ls/default_http
branch
from
3102a6f
to
e320acd
Compare
|
@ofedoren updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
An option for making HTTP proxy the default content proxy after creation.
Considerations taken when implementing this change?
https://issues.redhat.com/browse/SAT-28860
What are the testing steps for this pull request?
default content = truecontent_default_http_proxysetting