Fixes #37929 - support download policies for file

[sbernhard]

Support immediate and on-demand for file repos.

[ianballou]

Did all of the VCR tests here need to be rerecorded? We only rerecord all at once when doing Pulp upgrades, unless a feature seems to actually touch >~70% of the VCR tests.

As for why some are failing still, there could be a couple reasons. The Pulp bindings you used to record the VCRs could be different from what's used in CI here (bundle update will fix it). Or, there could be a random element in the test that is being passed to the Pulp API bindings. Random values being sent to the API will always cause VCR errors because they'll no longer match the recorded VCR.

[sbernhard]

Did all of the VCR tests here need to be rerecorded? We only rerecord all at once when doing Pulp upgrades, unless a feature seems to actually touch >~70% of the VCR tests.

As for why some are failing still, there could be a couple reasons. The Pulp bindings you used to record the VCRs could be different from what's used in CI here (bundle update will fix it). Or, there could be a random element in the test that is being passed to the Pulp API bindings. Random values being sent to the API will always cause VCR errors because they'll no longer match the recorded VCR.

Thanks for the help. Updated only the necessary vcrs. Actually one test failing - and no clue why 😤

[ianballou]

Error: Failure: test_chunk_upload

You likely need to set 'ORPHAN_PROTECTION_TIME = 0' in pulp's settings.py.

Does test/services/katello/pulp3/content_test.rb pass locally for you? I wonder if it was rerecorded with a Pulp state that caused it to fail.

[sbernhard]

Error: Failure: test_chunk_upload

You likely need to set 'ORPHAN_PROTECTION_TIME = 0' in pulp's settings.py.

Does test/services/katello/pulp3/content_test.rb pass locally for you? I wonder if it was rerecorded with a Pulp state that caused it to fail.

currently I run into:

Error:
Katello::Service::Pulp3::ContentTest#test_chunk_upload:
PulpFileClient::ApiError: Error message: the server returns an error
HTTP status code: 503
Response headers: {"date"=>"Mon, 04 Nov 2024 14:25:38 GMT", "server"=>"Apache", "content-length"=>"299", "connection"=>"close", "content-type"=>"text/html; charset=iso-8859-1"}
Response body:

<title>503 Service Unavailable</title>

Service Unavailable

The server is temporarily unable to service your request due to maintenance downtime or capacity problems. Please try again later.

/home/vagrant/katello/app/services/katello/pulp3/repository.rb:195:in `list'
/home/vagrant/katello/test/support/pulp3_support.rb:26:in `ensure_creatable'
/home/vagrant/katello/test/support/pulp3_support.rb:74:in `create_repo'
/home/vagrant/katello/test/services/katello/pulp3/content_test.rb:20:in `setup'
/home/vagrant/katello/test/support/vcr.rb:24:in `block in run'
/home/vagrant/katello/test/support/vcr.rb:23:in `run'

[sbernhard]

Looks like, the tests are now green @ianballou

[sbernhard]

Should I rebase everyting to a single commit or is it fine to have multiple commits for specific changes?

[ianballou]

Should I rebase everyting to a single commit or is it fine to have multiple commits for specific changes?

We can do a squash merge, so it's no problem.

[ianballou]

This looks good to me! Let's wait until branching happens to merge. It should be soon.

[ianballou]

@sbernhard I'm ready to merge this, but GH is complaining about conflicts. Mind updating them? The conflicts might relate to the recent branching.

[sbernhard]

Done @ianballou