Fixes #37941 - Handle AK creation params sent by AngularJS #11191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjha4
reviewed
Oct 31, 2024
jeremylenz
force-pushed
the
37941-angular-ak-create
branch
from
3d635e3
to
d45598e
Compare
|
updated with your suggestion @sjha4 |
jeremylenz
force-pushed
the
37941-angular-ak-create
branch
2 times, most recently
from
e8ff943
to
a687470
Compare
jeremylenz
force-pushed
the
37941-angular-ak-create
branch
from
a687470
to
866f232
Compare
|
It looks good to me 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
During activation key create, the controller assigns content view environments like so:
Due to recent changes,
update_cves?was always returning false when creating an AK from the AngularJS web UI. This is because (for some reason) the page sendsenvironmentandcontent_view_idparams, a combination that was not previously accounted for. This PR updatesupdate_cves?to handle that.Considerations taken when implementing this change?
We sure have a lot of weirdness from AngularJS that we compensate for in the controllers. When the page is removed (someday) I hope we can simplify our code accordingly.
What are the testing steps for this pull request?
Create an activation key in the web UI
Select a lifecycle env and content view
Ensure that the AK gets created with the LCE/CV