-
Notifications
You must be signed in to change notification settings - Fork 36
Isabelle Translation #3514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Isabelle Translation #3514
Conversation
fixed bugs in FieldHandler SortDependingHandler
Removed faulty arr function translation
Translates sorts without using illegal chars also handling exceptions from IsabelleMasterHandler
…. Also add types to sortdependingfunction references
@BookWood7th What is the state of this PR? It is still marked as Draft, and out of date with main. If I remember correctly, it should be nearly main-ready. What is still missing? |
I am currently updating the branch and applying a workaround for the automation features. Isabelle doesn't always manage to close all instances of the "e" prover it opened during sledgehammering, which causes a buildup of eprover instances running in the background. For now removing this prover from the sledgehammer toolkit should still leave the user with ample reasoning power via the other provers, namely cvc4 verit z3 spass vampire zipperposition. |
There is also still the somewhat strange Git behavior in this PR. The history suggests I deleted the KeYProject main branch. Should this be a new PR or should it be ignored? |
Change messages to inform user of likely incompatibility with newer Isabelle versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this nice addition to KeY!
I have only two minor points:
-
There are some classes (e.g.,
ProofApplyUserAction
) which have a very generic name, but are Isabelle-specific. Can you please adapt the names?
(For the handlers, I think it is ok since this way it is immediately visible that they follow the same structure as the SMT handlers.) -
Bug #3601 also exists for Isabelle, it should be easy to fix, I suggested an idea.
...etranslation/src/main/java/org/key_project/isabelletranslation/gui/ProofApplyUserAction.java
Outdated
Show resolved
Hide resolved
...etranslation/src/main/java/org/key_project/isabelletranslation/gui/ProofApplyUserAction.java
Outdated
Show resolved
Hide resolved
...ion/src/main/java/org/key_project/isabelletranslation/gui/controller/TranslateAllAction.java
Outdated
Show resolved
Hide resolved
...tion/src/main/java/org/key_project/isabelletranslation/gui/controller/TranslationAction.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the undo bug! There is an ongoing discussion on how to best implement the undo operation in #3606, but I think this is a separate point. Since everything works here, it should be merged now.
Intended Change
Adds a plugin, which allows the user to automatically translate a KeY sequent to an Isabelle theory and run parts of the automation of Isabelle on the translation. As presented at the KeY Symposium 2024
This broadens the automated toolset of KeY users, which allows for more automated proofs.
Type of pull request
Ensuring quality
Additional information and contact(s)
Thesis containing additional information (https://publikationen.bibliothek.kit.edu/1000176239)
The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.