Repository navigation
SDK update - #20
SDK update#20
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 814a9a6c2c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| """Return the latest turn, with ``completed=False`` until server confirmation.""" | ||
| terminal = self._terminal | ||
| failed = bool(terminal and terminal.type in {"fail", "rejected"}) | ||
| return AgentResult(text="".join(self._segments.values()), provider=self.provider.value, |
There was a problem hiding this comment.
When a valid sequenced chat_complete carries the final answer in content without preceding assistant-text segments, the session reports completed=True but returns an empty result.text: AgentEvent.from_wire() preserves that terminal content, while this assembly reads only _segments. Use the completion text as a fallback when no segments were delivered, while continuing to ignore it when it would duplicate segmented output.
Useful? React with 👍 / 👎.
chreia
changed the title
No description provided.