Repository navigation
fix: visibility contract + land internal-service secret auth (prod pin parity) - #23
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two contract fixes that prod needs together:
1. Send
visibilityinstead of legacyis_public(#22, already on main). The backend hard-rejectsis_publicon/synthesis/landscapeand/synthesis/githubsince MantisAPI #1958 (Jul 2026). Every SDK-driven space creation against prod has been 400-ing since; the repo_radar daily task is the most visible victim (runs green, produces nothing — its data is from June 20).2. Land the internal-service secret auth that prod already runs. The current prod pin
ca8bab2comes from the open PR #12 branch, not main. The MantisAPI backend (middleware.py) now fail-closes internal-service auth withoutX-Internal-Secretin production — a main-based pin without these commits would lose radar's backend auth entirely. These 5 commits are Pranava's PR #12 work (cherry-picked unchanged, same SHAs' content), which has been running in production since Aug 7 but was never merged to main. This PR merges that content so main = prod behavior + the visibility fix.Why cherry-pick instead of merging PR #12 directly
PR #12's branch is based on an older main and its head
74af9dcpredates #22; merging both would require PR #12 to be rebased. This PR applies the same 5 commits (identical patch content) on top of current main + #22, then runs the combined test suite.Verification
Full test suite on this branch: 78 passed (72 on main after #22, plus 6 auth tests from the PR #12 commits: secret required, secret sent, token redaction, cookie preservation with incomplete internal settings).
After merge
Bump
SDK_COMMITin MantisAPIsrc/mantis4mantis/repo_radar_task.pyto the merge SHA (tracked in the MantisAPI regression issue).