[refactor] 주소등록,계좌등록 뒤로가기 수정#491
Merged
geumyoung00 merged 2 commits intoKernel360:developfrom Aug 6, 2025
Merged
Conversation
Contributor
검토자 가이드계정 및 주소 헤더 컴포넌트의 뒤로 가기 버튼 동작을 리팩토링합니다. 일반적인 컨텍스트 인식 뒤로 가기 버튼 탐색을 위한 시퀀스 다이어그램sequenceDiagram
actor User
participant HeaderComponent as Account/AddressHeader
participant Router
User->>HeaderComponent: Clicks back button
HeaderComponent->>HeaderComponent: handleOnClick()
alt On /create or /edit page
HeaderComponent->>Router: push('/account' or '/address')
else On management page
HeaderComponent->>Router: push('/profile')
end
파일 수준 변경 사항
팁 및 명령어Sourcery와 상호 작용하기
경험 사용자 지정대시보드에 접속하여 다음을 수행할 수 있습니다:
도움말Original review guide in EnglishReviewer's GuideRefactor back button behavior in account and address header components by introducing a context-aware handler that routes users to listing or profile pages based on the current path, replacing the generic history.back() call. Sequence diagram for context-aware back button navigationsequenceDiagram
actor User
participant HeaderComponent as Account/AddressHeader
participant Router
User->>HeaderComponent: Clicks back button
HeaderComponent->>HeaderComponent: handleOnClick()
alt On /create or /edit page
HeaderComponent->>Router: push('/account' or '/address')
else On management page
HeaderComponent->>Router: push('/profile')
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
안녕하세요 @miniseung - 변경 사항을 검토했는데 훌륭해 보입니다!
AI 에이전트 프롬프트
이 코드 검토의 의견을 처리해 주세요:
## 개별 의견
### 의견 1
<location> `apps/web/src/components/layout/header/account.tsx:20` </location>
<code_context>
: '계좌 관리';
+ const handleOnClick = () => {
+ if (pathname.includes('/create') || pathname.includes('/edit')) {
+ routes.push('/account');
+ } else {
+ routes.push('/profile');
+ }
</code_context>
<issue_to_address>
Using pathname.includes may lead to false positives if route names overlap.
This approach may incorrectly match routes containing '/create' or '/edit' as substrings. Consider a stricter path check if your routing is complex.
</issue_to_address>제가 더 유용해질 수 있도록 도와주세요! 각 댓글에 👍 또는 👎를 클릭해 주시면 피드백을 사용하여 검토를 개선하겠습니다.
Original comment in English
Hey @miniseung - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `apps/web/src/components/layout/header/account.tsx:20` </location>
<code_context>
: '계좌 관리';
+ const handleOnClick = () => {
+ if (pathname.includes('/create') || pathname.includes('/edit')) {
+ routes.push('/account');
+ } else {
+ routes.push('/profile');
+ }
</code_context>
<issue_to_address>
Using pathname.includes may lead to false positives if route names overlap.
This approach may incorrectly match routes containing '/create' or '/edit' as substrings. Consider a stricter path check if your routing is complex.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+20
to
+22
| if (pathname.includes('/create') || pathname.includes('/edit')) { | ||
| routes.push('/account'); | ||
| } else { |
Contributor
There was a problem hiding this comment.
issue (bug_risk): pathname.includes를 사용하면 경로 이름이 겹칠 경우 오탐지가 발생할 수 있습니다.
이 접근 방식은 '/create' 또는 '/edit'과 같은 부분 문자열을 포함하는 경로를 잘못 일치시킬 수 있습니다. 라우팅이 복잡하다면 더 엄격한 경로 확인을 고려하세요.
Original comment in English
issue (bug_risk): Using pathname.includes may lead to false positives if route names overlap.
This approach may incorrectly match routes containing '/create' or '/edit' as substrings. Consider a stricter path check if your routing is complex.
geumyoung00
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 풀 리퀘스트 제안
📋 작업 내용
주소 등록, 계좌 등록 뒤로가기 수정
🔧 변경 사항
주요 변경 사항을 요약해 주세요.
📸 스크린샷 (선택 사항)
수정된 화면 또는 기능을 시연할 수 있는 스크린샷을 첨부해 주세요.
📄 기타
추가적으로 전달하고 싶은 내용이나 특별한 요구 사항이 있으면 작성해 주세요.
Sourcery 요약
AddressHeader 및 AccountHeader 뒤로 가기 버튼 동작을 컨텍스트별 경로로 이동하도록 리팩터링
개선 사항:
Original summary in English
Summary by Sourcery
Refactor AddressHeader and AccountHeader back button behavior to navigate to context-specific routes
Enhancements: