Repository navigation
Add Judge Trudy verdicts - #47
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
A new build was pushed to Chromatic! 🚀 |
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Adds scripts/build-verdicts-page.mjs, which writes __docs__/verdicts.mdx with every ruling as literal markdown and the two JSON files in fenced blocks, so tools reading the page over MCP get the rulings as text and can parse the raw data. pnpm verdicts:check runs in the Build check workflow and fails if the page is out of date with the JSON. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The page is reference data for the prototype builder's audit, not a guideline, so it shouldn't sit in the left nav beside them. Note: this drops the `dev` tag from the index as intended, but Storybook 10.3.5 still lists the entry in the sidebar. The page stays reachable by URL and over the MCP docs tools either way. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Regenerates __docs__/verdicts.mdx so pnpm verdicts:check stays green. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Adds verdicts/evaluations/ with the scaffolding-surfaces evaluation, and links it from Ruling 2 and Follow-up 2. Regenerates the docs page. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The evaluation block reached only the page's raw JSON, so a reader saw no sign that Ruling 2 had been scored. Renders outcome, score and path on the ruling and on its follow-up. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
jonahgoldsaito
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a home for Judge Trudy verdicts: Design Infra's rulings on how Wonder Blocks is meant to be used, and the follow-up work they create. The prototype builder skill's audit reads them, so every prototype gets the same rulings instead of each person's copy of the skill.
Starts with the four rulings from the practice display settings prototype:
stylesprop (position, margins, size, alignment) isn't drift; visual overrides are. No guideline yet.aria-expanded.<input type="color">isn't drift. Scoped to that one instance, not a general rule about native controls.Discussion: #design-infra thread, https://khanacademy.slack.com/archives/C0BHXK7RFFE/p1793208713508319
Issue: none
The rulings also render as a Verdicts docs page (
__docs__/verdicts.mdx), generated from the two JSONfiles by
pnpm verdicts:page.pnpm verdicts:checkruns in the Build check workflow and fails if the pageis out of date with them. The page is tagged
!devto keep it out of the left nav — note that Storybook10.3.5 still lists it; it's reachable by URL and over the MCP docs tools either way.
Test plan:
verdicts/verdicts.jsonand check the four entries match the rulings in the Slack thread.verdicts/requests review from Design Infra.🤖 Generated with Claude Code