Add file input support to Chat Completion types #4
+131
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces ChatMessagePartFile struct and ChatMessagePartTypeFile constant to support file attachments in chat messages. Updates ChatMessagePart to include file parts and adds comprehensive tests for serialization, deserialization, and constant definitions.
Refactored struct name for file parts in chat messages from ChatMessagePartFile to ChatMessageFile for consistency and clarity.
Corrected the indentation of the File field in the ChatMessagePart struct for improved code readability and consistency.
Replaces usage of ChatMessagePartFile with ChatMessageFile in chat_test.go to reflect updated type naming in the openai package. Also renames related test function for consistency.
Split a long conditional statement in TestMultipartChatMessageSerialization for improved readability.
Co-authored-by: Copilot <[email protected]>
…based (sashabaranov#1079) fixes sashabaranov#978 Signed-off-by: Christopher Petito <[email protected]>
kabirkhan
changed the title
rjcorwin
approved these changes
Oct 29, 2025
Comment on lines
+74
to
+78
| // only 3.5 models have the "." stripped in their names | ||
| if strings.Contains(model, "3.5") { | ||
| return regexp.MustCompile(`[.:]`).ReplaceAllString(model, "") | ||
| } | ||
| return strings.ReplaceAll(model, ":", "") |
There was a problem hiding this comment.
Looks like this is the latest from upstream main. No worries from me about this.
Comment on lines
+84
to
+103
| // ChatMessageFile is a placeholder for file parts in chat messages. | ||
| type ChatMessageFile struct { | ||
| FileID string `json:"file_id,omitempty"` | ||
| FileName string `json:"filename,omitempty"` | ||
| FileData string `json:"file_data,omitempty"` // Base64 encoded file data | ||
| } | ||
|
|
||
| type ChatMessagePartType string | ||
|
|
||
| const ( | ||
| ChatMessagePartTypeText ChatMessagePartType = "text" | ||
| ChatMessagePartTypeImageURL ChatMessagePartType = "image_url" | ||
| ChatMessagePartTypeFile ChatMessagePartType = "file" | ||
| ) | ||
|
|
||
| type ChatMessagePart struct { | ||
| Type ChatMessagePartType `json:"type,omitempty"` | ||
| Text string `json:"text,omitempty"` | ||
| ImageURL *ChatMessageImageURL `json:"image_url,omitempty"` | ||
| File *ChatMessageFile `json:"file,omitempty"` |
There was a problem hiding this comment.
Assuming these all checkout to what OpenAI expects, LGTM. Alas, I'm failing to find where this API is documented in their chat completion API documentation.
There was a problem hiding this comment.
@rjcorwin this is what I've seen. It's not easy to find: https://platform.openai.com/docs/api-reference/chat/create#chat_create-messages-user_message-content-array_of_content_parts-file_content_part-file
matthewmorgan
approved these changes
Oct 29, 2025
There was a problem hiding this comment.
Thanks @kabirkhan ! I feel good about this knowing you and @rjcorwin have both looked at it. Looks correct to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to the most recent
sashabaranov/masterchanges.Also merge the commits from this currently Open PR: sashabaranov#1056
This change adds support for the File input parameters to the Chat Completions API and supports the Document input work in ai-guide.