Integrate e2e-test-cycloud job with Buildmaster #260
Conversation
Issue: FEI-6125
jobs/e2e-test-cycloud.groovy
Outdated
|
|
||
| dir('webapp/services/static') { | ||
| // We build the secrets first, so that we can create test users in our | ||
| // tests. | ||
| sh("yarn cypress:secrets"); |
There was a problem hiding this comment.
Cc @jeresig -- is this something we need to be doing some other way, now?
There was a problem hiding this comment.
Yes - this will need to use the new wrapper script I added here: https://github.com/Khan/webapp/pull/28829 good catch! I'm going to be landing the script to master today.
There was a problem hiding this comment.
We don't need to call yarn cypress:secrets at all. Secrets are handled internally to the CyCloud runner and passed as environment variables option, rather than a JSON file.
There was a problem hiding this comment.
Yeah, makes sense we can remove this yarn secrets call.
jobs/e2e-test-cycloud.groovy
Outdated
| def resultsDir = "results"; // Directory to store results | ||
| def junitFile = "${resultsDir}/junit-${workerId}.xml"; | ||
|
|
||
| // Ensure the results directory exists |
There was a problem hiding this comment.
Don't you also need to clear out any old xml files that might be there?
There was a problem hiding this comment.
Oh, thanks! Yeah, we need to clean up the old xml files first to avoid conflicts.
jobs/e2e-test-cycloud.groovy
Outdated
| "./dev/cypress/e2e/tools/start-cypress-cloud-run.ts", | ||
| "--cyConfig baseUrl=\"${E2E_URL}\"", | ||
| "--reporter mocha-junit-reporter", | ||
| "--reporter-options mochaFile=${junitFile}" |
There was a problem hiding this comment.
note: This invocation will need to change. These args aren't supported by the runner and I'm not sure we need to provide them like this. I think most of this can be calculated internally to the code.
There was a problem hiding this comment.
In addition, we're not going to do junit right away. That's a stretch goal once we have things working.
Issue: FEI-6125
Summary:
This draft PR introduces a Cypress Cloud job that runs in parallel with the existing Lambda e2e-test job. It also includes a Mocha implementation for each worker. (Note: The Mocha implementation requires updates with
yarn, which can be addressed in a subsequent PR.)The primary goal is to utilize Jenkins stash functionality to capture and merge all junit reports into a single file, enabling streamlined processing.