[Accessibility] Add accessibility checker in editor #2219
+471
−87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssibility-panel-in-editor
Add event listener for updates to the preview panel so that axe-core can re-test the updates.
…ssibility-panel-in-editor
…cons consistent (used to be two different sizes). Make widget editor panel transition when toggled. Adjust axe-core settings when in Storybook so that it scans the correct preview element. Add status icon to accessibility panel. Add issues panels for violations and inconsistencies.
…ssibility-panel-in-editor
Add "Show Me" toggle to highlight the offending element.
|
Size Change: +2.63 kB (+0.3%) Total Size: 869 kB
ℹ️ View Unchanged
|
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (284d21f) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR2219If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR2219 |
…ry 1.5 seconds since message event is called twice per second in PROD.
…ists in the iframe, and add it if it's missing.
…iframe. Add check to ensure that axe-core is installed before trying to execute it.
…ments for iFrame context. Add styling to enable "Show Me" rectangle to show above iFrame.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Test plan: