[LEMS-2852] Answerless Expression #2226
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +137 B (+0.02%) Total Size: 871 kB
ℹ️ View Unchanged
|
handeyeco
changed the title
handeyeco
changed the title
handeyeco
commented
Feb 13, 2025
Comment on lines
842
to
844
| "extraKeys": [ | ||
| "PI", | ||
| ], |
There was a problem hiding this comment.
Maybe instead of having deriveExtraKeys default to ["PI"] it should just be empty and the props can default to ["PI"] when rendering...
| @@ -0,0 +1,77 @@ | |||
| import * as KAS from "@khanacademy/kas"; | |||
There was a problem hiding this comment.
I just need to work with Jeremy to figure out this import stuff. There's a weird issue with a circular dependency that I wasn't able to figure out.
| expect(score).toHaveBeenAnsweredCorrectly(); | ||
| }); | ||
|
|
||
| it("is interactive with answerless widget options", async () => { |
There was a problem hiding this comment.
This is the important one. Without answer data we:
- Render
- Answer
- Send the input off for scoring
| * to be included as keys on the keypad. These are scraped from the answer | ||
| * forms. | ||
| */ | ||
| export const keypadConfigurationForProps = ( |
There was a problem hiding this comment.
Most of this logic was for deriving extra keys, so I just transformed this into deriveExtraKeys.
handeyeco
commented
Feb 19, 2025
| buttonsVisible: v0options.buttonsVisible, | ||
| visibleLabel: v0options.visibleLabel, | ||
| ariaLabel: v0options.ariaLabel, | ||
| extraKeys: v0options.extraKeys, |
handeyeco
commented
Feb 19, 2025
| extraKeys: v1options.extraKeys || deriveExtraKeys(v1options), | ||
| }; | ||
| }, | ||
| "1": (v0options: any): PerseusExpressionWidgetOptions => { |
There was a problem hiding this comment.
This probably shouldn't return PerseusExpressionWidgetOptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
So the main thing with the Expression widget is that it was using answer data to determine which
extraKeysto show in theMathInputkeypad. For instance if a possible answer was42i, it would showiin theExtratab on the keypad.This PR sets us up for removing answers by adding
extraKeysto the data schema so it can be determined at publish time rather than read time. We simulate this by upgrading the widget to provideextraKeyswhen not present on the data.Issue: LEMS-2852
Test plan: