Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR Tree] Add infotip with explanation about SR Tree #2256

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nishasy
Copy link
Contributor

@nishasy nishasy commented Feb 20, 2025

Summary:

It was a little unclear which graph the SR Tree was for.

Add a clarifying InfoTip explaning that it's for the
"correct answer" graph.

Issue: none

Test plan:

Storybook

image

It was a little unclear which graph the SR Tree was for.

Add a clarifying InfoTip explaning that it's for the
"correct answer" graph.

Issue: none

Test plan:
Storybook
- http://localhost:6006/?path=/story/perseuseditor-widgets-interactive-graph--interactive-graph-with-aria-label
@nishasy nishasy self-assigned this Feb 20, 2025
@nishasy nishasy requested a review from a team February 20, 2025 00:05
Copy link
Contributor

Size Change: +35 B (0%)

Total Size: 1.47 MB

Filename Size Change
packages/perseus-editor/dist/es/index.js 689 kB +35 B (+0.01%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 39 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 86.9 kB
packages/math-input/dist/es/index.js 77.7 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 48.2 kB
packages/perseus-linter/dist/es/index.js 22.1 kB
packages/perseus-score/dist/es/index.js 115 kB
packages/perseus/dist/es/index.js 367 kB
packages/perseus/dist/es/strings.js 6.57 kB
packages/pure-markdown/dist/es/index.js 3.66 kB
packages/simple-markdown/dist/es/index.js 12.5 kB

compressed-size-action

Copy link
Contributor

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (ad670e2) and published it to npm. You
can install it using the tag PR2256.

Example:

yarn add @khanacademy/perseus@PR2256

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR2256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant