Add workflow to check determinism#1164
Merged
MarkCallow merged 39 commits intomainfrom May 5, 2026
Merged
Conversation
Update CTS ref for updated golden files. This avoids a bug in macOS 15 era AppleClang where it searches system includes before directories specified with -isystem. This became a problem when some Actions runners had a different version of zstd installed in /usr/local/include.
Comment out additions to help debug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A manually dispatched workflow to that runs the CTS, set to require exact matches to golden files, on macOS, Ubuntu and Windows using arm64 and x86_86 processors, with
ktxandlibktxcompiled with clang and gcc and, in addition, on macOS AppleClang and on Windows ClangCL and msvc.Of necessity to avoid a build failure on the macos-15-intel runner, update the version of zstd included in
external/basis_universal/zstd.The failure arose due to a combination of three factors: zstd_errors.h was not in
external/basis_universal/zstdbut inother_Includewhich is marked as a system directory; macos-15-intel has a newer version installed in/usr/local/includewhich omits declaration of a function libktx uses; the AppleClang version on that runner was searching/usr/local/includebefore directories specified with-isystem, in what looks like a bug. The updated version, from basis_universal 2.0, declares the function that libktx uses inzstd.h. Furthermore it includeszstd_errors.hin the same directory nullifying the-isystemand conflicting version problems.