Fix tolerance handling for unnormalized formats#1166
Merged
MarkCallow merged 8 commits intomainfrom May 7, 2026
Merged
Conversation
Fix setting of isNormalized.
when comparing unnormalized images. Use asctenc_mathlib for float16_to_float.a Replace isFormatAstc switch function with check of DFD color model. Add compareUnorm16.
* merge issues from rebase; * use imageio::half_to_float conversion instead of astcenc's; * interpret tolerance as a percentage of the min of the two values.
Restore the return/exit on failure.
Update test ref for modified tolerances.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tolerance for unnormalized formats is now specified as a fraction of the minimum of the two values being compared, given as a value between 0 and 1. For normalized formats the tolerance is, as before, specified as the normalized value of the acceptable difference.
The PR also adds a comparison for 16-bit unorm values.