Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTLHeaps on Apple Device Simulator must use private storage #2473

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

SRSaunders
Copy link
Contributor

Fixes #2472

Copy link
Collaborator

@cdavis5e cdavis5e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yet another instance where the Simulator disables Apple Silicon features on Apple Silicon GPUs for no real reason.

@SRSaunders
Copy link
Contributor Author

Yet another instance where the Simulator disables Apple Silicon features on Apple Silicon GPUs for no real reason.

Perhaps it's because the Simulator runs on both x86_64 and arm64 hosts, and Apple wants the same behaviour on both? Or perhaps they only want to maintain one code path? Note I actually tested this PR on both host arches to make sure it was truly necessary on arm64 hosts - and it is.

Copy link
Contributor

@billhollings billhollings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching, and thanks for the fix!

@billhollings billhollings merged commit 83510e0 into KhronosGroup:main Mar 19, 2025
6 checks passed
@SRSaunders SRSaunders deleted the heaps-sim-fix branch March 19, 2025 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MVK_CONFIG_USE_MTLHEAP default ON causes issues with Simulator
3 participants