Skip to content

Conversation

@dennyronngren
Copy link
Contributor

@dennyronngren dennyronngren commented Apr 4, 2023

Things done:

  • Moved runtime summary into "info"-modal popup in table to make table as the main feature
  • Clicking extension now moves to corresponding extension row in table
  • Removed some closing tags without start tags

@dennyronngren dennyronngren changed the title Featured table more and added modal popups for runtime details Featured table more since all info is condensed in there and fixed up some invalid html and unwanted line breaks Apr 4, 2023
@dennyronngren dennyronngren marked this pull request as ready for review April 20, 2023 17:39
@rpavlik
Copy link
Contributor

rpavlik commented Apr 27, 2023

oh this looks nice with the modals, though it looks like it breaks the links in the extension lists

image

@rpavlik rpavlik self-requested a review April 27, 2023 17:55
Copy link
Contributor

@rpavlik rpavlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to figure out what to do with the main-body links.

@dennyronngren
Copy link
Contributor Author

dennyronngren commented May 15, 2023

oh this looks nice with the modals, though it looks like it breaks the links in the extension lists

image

I think those could be removed, the information is in the main table header now. What do you think? (I already did the change locally... and it looks good to me, but thought we should chat about it first)

If not, it would link to the table headers (with the runtimes).

we need to figure out what to do with the main-body links.

Agreed, I think the "Extension" and "Runtime" might be ok to delete if we go with the change above. I pushed a new commit so you can see.

@BastiaanOlij
Copy link
Contributor

@dennyronngren were you still looking into this PR/have time to look into this, and could you rebase it?
Or would you be fine for me to take it over?

@dennyronngren
Copy link
Contributor Author

@dennyronngren were you still looking into this PR/have time to look into this, and could you rebase it? Or would you be fine for me to take it over?

Please take it over if you like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants