Skip to content

Unify group code snippet with other non-user-constructible classes #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlexeySachkov wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Unify group code snippet with other non-user-constructible classes #627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91dad3d
Unify `group` code snippet with other non-user-constructible classes
AlexeySachkov Sep 20, 2024
e41eda4
Also update sub_group in a similar way
AlexeySachkov Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions adoc/headers/group.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ template <int Dimensions = 1> class group {
static constexpr int dimensions = Dimensions;
static constexpr memory_scope fence_scope = memory_scope::work_group;

group() = delete;

/* -- common interface members -- */

id<Dimensions> get_group_id() const;
Expand Down
2 changes: 2 additions & 0 deletions adoc/headers/subgroup.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ class sub_group {
static constexpr int dimensions = 1;
static constexpr memory_scope fence_scope = memory_scope::sub_group;

sub_group() = delete;

/* -- common interface members -- */

id<1> get_group_id() const;
Expand Down